Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: tools/testing/dart/test_progress.dart

Issue 8873013: Get rid of the spinner in progress indicators. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_progress.dart
diff --git a/tools/testing/dart/test_progress.dart b/tools/testing/dart/test_progress.dart
index 5c682b4ef57b911ffc91f5db77ae3051e410bdd9..bcc94b4507758a94b897bf606552d7b695c0cdb3 100644
--- a/tools/testing/dart/test_progress.dart
+++ b/tools/testing/dart/test_progress.dart
@@ -165,14 +165,6 @@ class CompactIndicator extends ProgressIndicator {
void _printStartProgress(TestCase test) => _printProgress();
void _printDoneProgress(TestCase test) => _printProgress();
-
- String _nextSpinner() {
- _spinnerIndex = (_spinnerIndex + 1) % 4;
- return _spinners[_spinnerIndex];
- }
-
- static int _spinnerIndex = 0;
- static List<String> _spinners = const ['- ', '\\ ', '| ', '/ '];
}
@@ -181,8 +173,8 @@ class CompactProgressIndicator extends CompactIndicator {
: super(startTime, printTiming);
void _printProgress() {
- var percent = ((_completedTests() / _foundTests) * 100).floor().toString();
- var progressPadded = _pad(_allTestsKnown ? percent : _nextSpinner(), 5);
+ var percent = ((_completedTests() / _foundTests) * 100).toInt().toString();
+ var progressPadded = _pad(_allTestsKnown ? percent : '--', 3);
var passedPadded = _pad(_passedTests.toString(), 5);
var failedPadded = _pad(_failedTests.toString(), 5);
Duration d = (new Date.now()).difference(_startTime);
@@ -211,8 +203,8 @@ class ColorProgressIndicator extends CompactIndicator {
}
void _printProgress() {
- var percent = ((_completedTests() / _foundTests) * 100).floor().toString();
- var progressPadded = _pad(_allTestsKnown ? percent : _nextSpinner(), 5);
+ var percent = ((_completedTests() / _foundTests) * 100).toInt().toString();
+ var progressPadded = _pad(_allTestsKnown ? percent : '--', 3);
var passedPadded = _pad(_passedTests.toString(), 5);
var failedPadded = _pad(_failedTests.toString(), 5);
Duration d = (new Date.now()).difference(_startTime);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698