Issue 8873007: Remove custom Task implementation from process_util_win.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8873007: Remove custom Task implementation from process_util_win.cc. (Closed)

Created:
9 years ago by dcheng

Modified:
9 years ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove custom Task implementation from process_util_win.cc. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114169

Patch Set 4 : Address review comment. #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -40 lines)			Patch
	M	base/process_util_win.cc	View	1 2 3	4 chunks	+46 lines, -40 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

lgtm http://codereview.chromium.org/8873007/diff/3001/base/process_util_win.cc File base/process_util_win.cc (right): http://codereview.chromium.org/8873007/diff/3001/base/process_util_win.cc#newcode138 base/process_util_win.cc:138: TimerExpiredTask::~TimerExpiredTask() { Should this just call TimedOut() and ...

9 years ago (2011-12-13 00:41:14 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/8873007/5001

9 years ago (2011-12-13 01:07:00 UTC) #3

Change committed as 114169

Expand Messages | Collapse Messages

Issue 8873007: Remove custom Task implementation from process_util_win.cc. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Compile fix. #

Patch Set 3 : Fix indent #

Patch Set 4 : Address review comment. #

Messages