Fix safe-browsing sub parsing for download whitelist.

Fix safe-browsing sub parsing for download whitelist.

Sub chunks for kDownloadWhiteList are just a bunch of
(add_chunk_number, prefix) pairs, with no leading host/count.

Additionally, shift the buffer-overrun checks before the buffer is
overrun rather than after, and add DCHECKs to make sure this is
honored.

BUG=106165
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113566

[noelutz, 2011-12-08 03:26:54]

lgtm

thanks for fixing this so quickly!
noé.

http://codereview.chromium.org/8873004/diff/1/chrome/browser/safe_browsing/pr...
File chrome/browser/safe_browsing/protocol_parser.cc (right):

http://codereview.chromium.org/8873004/diff/1/chrome/browser/safe_browsing/pr...
chrome/browser/safe_browsing/protocol_parser.cc:448:
DCHECK_EQ(sizeof(*chunk_id), 4u);
good call.

[Scott Hess - ex-Googler, 2011-12-08 04:12:44]

http://codereview.chromium.org/8873004/diff/1/chrome/browser/safe_browsing/pr...
File chrome/browser/safe_browsing/protocol_parser.cc (right):

http://codereview.chromium.org/8873004/diff/1/chrome/browser/safe_browsing/pr...
chrome/browser/safe_browsing/protocol_parser.cc:448:
DCHECK_EQ(sizeof(*chunk_id), 4u);
On 2011/12/08 03:26:54, noelutz wrote:
> good call.

For all that I said "I don't have time to rewrite the parsing code" in the
associated bug, as I think about it it seems to me that cleaning it up might
only take a few hours.  Maybe a good investment of free time around the
holidays...

[commit-bot: I haz the power, 2011-12-08 04:13:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shess@chromium.org/8873004/1

[commit-bot: I haz the power, 2011-12-08 06:00:56]

Change committed as 113566