src/codegen-ia32.cc - Issue 8873: Allow three runtime call attempts before throwing an out of...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codegen-ia32.cc

Issue 8873: Allow three runtime call attempts before throwing an out of... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 12 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/codegen-ia32.cc

===================================================================

--- src/codegen-ia32.cc (revision 636)

+++ src/codegen-ia32.cc (working copy)

@@ -4955,7 +4955,8 @@

Label throw_out_of_memory_exception;

Label throw_normal_exception;

-#ifdef DEBUG

+ // Call into the runtime system. Collect garbage before the call if

+ // running with --gc-greedy set.

if (FLAG_gc_greedy) {

Failure* failure = Failure::RetryAfterGC(0);

__ mov(Operand(eax), Immediate(reinterpret_cast<int32_t>(failure)));

@@ -4964,14 +4965,17 @@

&throw_out_of_memory_exception,

frame_type,

FLAG_gc_greedy);

-#else

+ // Do space-specific GC and retry runtime call.

GenerateCore(masm,

&throw_normal_exception,

&throw_out_of_memory_exception,

frame_type,

- false);

-#endif

+ true);

+ // Do full GC and retry runtime call one final time.

+ Failure* failure = Failure::InternalError();

+ __ mov(Operand(eax), Immediate(reinterpret_cast<int32_t>(failure)));

GenerateCore(masm,

&throw_normal_exception,

&throw_out_of_memory_exception,

« no previous file with comments | « src/codegen-arm.cc ('k') | src/handles.cc » ('j') | no next file with comments »