Reland 10216 - Optimize the equality check case of ICCompare stubs.

Reland 10216 -  Optimize the equality check case of ICCompare stubs.

Now with arm and x64 support. Additionally, added default unreachable case to switch statement in CompareIC::TargetState to make win and mac compilers happy.

Reviewer guide:
This is an exact copy of 10216 except:
src/arm/*
src/x64/*
src/ic.cc (added default case to swith in CompareIC::TargetState)
Committed: http://code.google.com/p/v8/source/detail?r=10219

[Kevin Millikin (Chromium), 2011-12-09 09:10:31]

LGTM with a couple of small comments.

http://codereview.chromium.org/8872060/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/8872060/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:6740: __ Push(r1, r0);
You could move this (and the corresponding pops) to use the internal frame
instead of using the caller's frame.

http://codereview.chromium.org/8872060/diff/1/src/ic.cc
File src/ic.cc (right):

http://codereview.chromium.org/8872060/diff/1/src/ic.cc#newcode2369
src/ic.cc:2369: UNREACHABLE();
I'd rather have this outside the switch:

switch (state) {
  case ...  // Cases for all enum values.
}
UNREACHABLE();
return NULL;

[Rico, 2011-12-09 09:28:31]

http://codereview.chromium.org/8872060/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/8872060/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:6740: __ Push(r1, r0);
On 2011/12/09 09:10:31, Kevin Millikin wrote:
> You could move this (and the corresponding pops) to use the internal frame
> instead of using the caller's frame.

Done.

http://codereview.chromium.org/8872060/diff/1/src/ic.cc
File src/ic.cc (right):

http://codereview.chromium.org/8872060/diff/1/src/ic.cc#newcode2369
src/ic.cc:2369: UNREACHABLE();
On 2011/12/09 09:10:31, Kevin Millikin wrote:
> I'd rather have this outside the switch:
> 
> switch (state) {
>   case ...  // Cases for all enum values.
> }
> UNREACHABLE();
> return NULL;

Done.