Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp

Issue 8872059: Merge 102140 - [Chromium] Web Inspector: getFunctionLocation should return scriptId as String not... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/963/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebCore/ChangeLog ('k') | Source/WebCore/inspector/Inspector.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp
===================================================================
--- Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp (revision 102438)
+++ Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp (working copy)
@@ -167,7 +167,7 @@
v8::Local<v8::Object> result = v8::Object::New();
result->Set(v8::String::New("lineNumber"), v8::Integer::New(lineNumber));
result->Set(v8::String::New("columnNumber"), v8::Integer::New(columnNumber));
- result->Set(v8::String::New("scriptId"), function->GetScriptId());
+ result->Set(v8::String::New("scriptId"), function->GetScriptId()->ToString());
return result;
}
« no previous file with comments | « Source/WebCore/ChangeLog ('k') | Source/WebCore/inspector/Inspector.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698