Refactor MessagePumpX to dispatch events inside of the source Dispatch function.

Refactor MessagePumpX to dispatch events inside of the source Dispatch function.

Also clean up MessagePumpGlib.

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114168

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114439

[piman, 2011-12-09 02:45:45]

sadrul for review, darin for OWNERS.

This is written on top of http://codereview.chromium.org/8890042/ , I'll send
the trybots once that one has landed.

[sadrul, 2011-12-09 02:56:15]

Very very nice! Thanks for doing this. LGTM

http://codereview.chromium.org/8872055/diff/1/base/message_loop.cc
File base/message_loop.cc (right):

http://codereview.chromium.org/8872055/diff/1/base/message_loop.cc#newcode157
base/message_loop.cc:157: #define MESSAGE_PUMP_UI new base::MessagePumpX()
I think both MessagePumpGlib (for wayland) and MessagePumpX are typedef'ed to
MessagePumpForUI. In that case, perhaps merge OS_ANDROID, USE_WAYLAND and
USE_AURA (i.e. lines 150-158)?

[piman, 2011-12-09 03:46:50]

http://codereview.chromium.org/8872055/diff/1/base/message_loop.cc
File base/message_loop.cc (right):

http://codereview.chromium.org/8872055/diff/1/base/message_loop.cc#newcode157
base/message_loop.cc:157: #define MESSAGE_PUMP_UI new base::MessagePumpX()
On 2011/12/09 02:56:15, sadrul wrote:
> I think both MessagePumpGlib (for wayland) and MessagePumpX are typedef'ed to
> MessagePumpForUI. In that case, perhaps merge OS_ANDROID, USE_WAYLAND and
> USE_AURA (i.e. lines 150-158)?

Good point, we can even go one step further, and merge it with the Gtk version
(which is also typedef'd). So I did that.

[piman, 2011-12-09 23:00:45]

darin: OWNERS ping?

[darin (slow to review), 2011-12-13 00:57:30]

LGTM

[commit-bot: I haz the power, 2011-12-13 01:03:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/piman@chromium.org/8872055/7001

[commit-bot: I haz the power, 2011-12-13 01:05:15]

Try job failure for 8872055-7001 on win_rel for steps "update_scripts, update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2011-12-13 01:51:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/piman@chromium.org/8872055/7001

[commit-bot: I haz the power, 2011-12-13 03:05:41]

Change committed as 114168

[piman, 2011-12-13 21:56:44]

sadrul: PTAL. The change got reverted because it broke menus on aura, because
nested loop didn't pump events any more. This new patch fixes it (changing
g_source_set_can_recurse to TRUE).

[piman, 2011-12-14 01:56:10]

Sadrul looks out. oshima, mind taking a look?

[oshima, 2011-12-14 03:02:01]

LGTM

[commit-bot: I haz the power, 2011-12-14 08:34:48]

No LGTM from valid reviewers yet.

[commit-bot: I haz the power, 2011-12-14 14:41:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/piman@chromium.org/8872055/5012

[commit-bot: I haz the power, 2011-12-14 16:34:34]

Change committed as 114439