Print preview: Display a dummy page when a user visits chrome://print directly.

Print preview: Display a dummy page when a user visits chrome://print directly.

BUG=106614
TEST=See bug.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114285

[Lei Zhang, 2011-12-09 01:16:56]

http://codereview.chromium.org/8872051/diff/1/chrome/browser/resources/print_...
File chrome/browser/resources/print_preview/print_preview.css (right):

http://codereview.chromium.org/8872051/diff/1/chrome/browser/resources/print_...
chrome/browser/resources/print_preview/print_preview.css:424: #dummy-box {
CSS from dbeam. This would have taken me *years*.

http://codereview.chromium.org/8872051/diff/1/chrome/browser/resources/print_...
File chrome/browser/resources/print_preview/print_preview.html (left):

http://codereview.chromium.org/8872051/diff/1/chrome/browser/resources/print_...
chrome/browser/resources/print_preview/print_preview.html:19: <script
src="chrome://resources/js/event_tracker.js"></script>
duplicate

http://codereview.chromium.org/8872051/diff/1/chrome/browser/ui/webui/constra...
File chrome/browser/ui/webui/constrained_html_ui.cc (right):

http://codereview.chromium.org/8872051/diff/1/chrome/browser/ui/webui/constra...
chrome/browser/ui/webui/constrained_html_ui.cc:32:
ChromeWebUI::RenderViewCreated(render_view_host);
Better to just do this first.

[dpapad, 2011-12-12 19:26:30]

I am getting the following warning/error in the js console,
"Refused to execute inline script because of Content-Security-Policy."

Is there a way to fix that?

http://codereview.chromium.org/8872051/diff/1/chrome/browser/resources/print_...
File chrome/browser/resources/print_preview/print_preview.css (right):

http://codereview.chromium.org/8872051/diff/1/chrome/browser/resources/print_...
chrome/browser/resources/print_preview/print_preview.css:424: #dummy-box {
On 2011/12/09 01:16:56, Lei Zhang wrote:
> CSS from dbeam. This would have taken me *years*.

Made some small changes to in order to have the "This page is intentionally left
blank" message wrapping when the window size is small.

http://codereview.chromium.org/8872051/diff/1/chrome/browser/ui/webui/print_p...
File chrome/browser/ui/webui/print_preview_ui.h (right):

http://codereview.chromium.org/8872051/diff/1/chrome/browser/ui/webui/print_p...
chrome/browser/ui/webui/print_preview_ui.h:170: // Whether the user visited the
page directly, or if it's a live UI.
Nit: True if the user visited the page directly, false if it's a live UI.

[Lei Zhang, 2011-12-13 02:25:19]

Fixed the Content-Security-Policy issue too.

http://codereview.chromium.org/8872051/diff/1/chrome/browser/resources/print_...
File chrome/browser/resources/print_preview/print_preview.css (right):

http://codereview.chromium.org/8872051/diff/1/chrome/browser/resources/print_...
chrome/browser/resources/print_preview/print_preview.css:424: #dummy-box {
On 2011/12/12 19:26:30, dpapad wrote:
> On 2011/12/09 01:16:56, Lei Zhang wrote:
> > CSS from dbeam. This would have taken me *years*.
> 
> Made some small changes to in order to have the "This page is intentionally
left
> blank" message wrapping when the window size is small.

Sure.

http://codereview.chromium.org/8872051/diff/1/chrome/browser/ui/webui/print_p...
File chrome/browser/ui/webui/print_preview_ui.h (right):

http://codereview.chromium.org/8872051/diff/1/chrome/browser/ui/webui/print_p...
chrome/browser/ui/webui/print_preview_ui.h:170: // Whether the user visited the
page directly, or if it's a live UI.
On 2011/12/12 19:26:30, dpapad wrote:
> Nit: True if the user visited the page directly, false if it's a live UI.

Done.

[dpapad, 2011-12-13 17:00:42]

LGTM.

http://codereview.chromium.org/8872051/diff/8002/chrome/browser/ui/webui/prin...
File chrome/browser/ui/webui/print_preview_ui.cc (right):

http://codereview.chromium.org/8872051/diff/8002/chrome/browser/ui/webui/prin...
chrome/browser/ui/webui/print_preview_ui.cc:84: is_dummy_ = true;
Nit (optional):
is_dummy_ = (!controller || !controller->is_creating_print_preview_tab());

[Lei Zhang, 2011-12-13 20:34:30]

http://codereview.chromium.org/8872051/diff/8002/chrome/browser/ui/webui/prin...
File chrome/browser/ui/webui/print_preview_ui.cc (right):

http://codereview.chromium.org/8872051/diff/8002/chrome/browser/ui/webui/prin...
chrome/browser/ui/webui/print_preview_ui.cc:84: is_dummy_ = true;
On 2011/12/13 17:00:43, dpapad wrote:
> Nit (optional):
> is_dummy_ = (!controller || !controller->is_creating_print_preview_tab());

Done.

[commit-bot: I haz the power, 2011-12-13 20:36:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/8872051/6007

[commit-bot: I haz the power, 2011-12-13 22:14:19]

Change committed as 114285