Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 8872047: Respect default browser policy (Closed)

Created:
9 years ago by benwells
Modified:
9 years ago
CC:
chromium-reviews, pastarmovj
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Respect default browser policy This got broken with an earlier change to perform the change to the default browser setting on the FILE thread. The file thread isn't created at the point the default browser policy is enforced, this change moves the code to later in the startup process. BUG=106610 TEST=Manual testing performed with a hacked Chromium to always set Chrome as the default regardless of local policy. QA should test with all the policy machinery setup. Linux and Mac should be tested as well. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/browser/browser_process_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
benwells
Moved code to later in the startup process. Apologies for breaking this in the first ...
9 years ago (2011-12-08 23:41:11 UTC) #1
Mattias Nissler (ping if slow)
LGTM, thanks for fixing!
9 years ago (2011-12-09 09:33:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/8872047/1
9 years ago (2011-12-11 22:42:44 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-12 03:04:18 UTC) #4
Change committed as 113977

Powered by Google App Engine
This is Rietveld 408576698