Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 8872045: Fix PluginImageData and mouselock NaCl example: (Closed)

Created:
9 years ago by yzshen1
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix PluginImageData and mouselock NaCl example: - Fix the memory leak in PluginImageData. - Fix the out-of-bound memory access in mouselock NaCl example. BUG=106779 TEST=mouselock NaCl example won't crash after a while (~30 seconds). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113854

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M native_client_sdk/src/examples/mouselock/mouselock.cc View 3 chunks +18 lines, -8 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_image_data.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_image_data.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
yzshen1
Hi, Dave. Please take a look. Thanks!
9 years ago (2011-12-08 23:24:24 UTC) #1
mball
After this is committed, we should merge the updated example to https://nativeclient-sdk.googlecode.com/svn/branches/cod/src so that the ...
9 years ago (2011-12-08 23:36:29 UTC) #2
yzshen1
On 2011/12/08 23:36:29, mball wrote: > After this is committed, we should merge the updated ...
9 years ago (2011-12-08 23:40:14 UTC) #3
mball
lgtm +noelallen, +bradnelson as native_client_sdk owners.
9 years ago (2011-12-08 23:59:38 UTC) #4
dmichael (off chromium)
LGTM, thanks for tracking that down!
9 years ago (2011-12-09 02:43:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/8872045/1
9 years ago (2011-12-09 08:10:18 UTC) #6
commit-bot: I haz the power
Presubmit check for 8872045-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-09 08:10:22 UTC) #7
noelallen1
lgtm
9 years ago (2011-12-09 18:37:26 UTC) #8
mball
I'll go ahead and merge the changes to the example over to the pepper_16 branch ...
9 years ago (2011-12-12 20:52:57 UTC) #9
yzshen1
9 years ago (2011-12-12 20:56:38 UTC) #10
On 2011/12/12 20:52:57, mball wrote:
> I'll go ahead and merge the changes to the example over to the pepper_16
branch
> in the old NaCl SDK repository...

Thanks!

Powered by Google App Engine
This is Rietveld 408576698