Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: chrome/browser/ui/panels/panel_strip.cc

Issue 8872044: Add test cases for panel overflow handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix per feedback Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_strip.cc
diff --git a/chrome/browser/ui/panels/panel_strip.cc b/chrome/browser/ui/panels/panel_strip.cc
index 976588a38d08bc63c53ee4c5dc4bf47d7776335c..c2ad7ef197086bdfafb09153a268dc9e2ec87ddd 100644
--- a/chrome/browser/ui/panels/panel_strip.cc
+++ b/chrome/browser/ui/panels/panel_strip.cc
@@ -179,7 +179,12 @@ bool PanelStrip::Remove(Panel* panel) {
}
DoRemove(panel);
- Rearrange();
+
+ // Don't rearrange the strip if a panel is being moved from the panel strip
+ // to the overflow strip.
+ if (panel->expansion_state() != Panel::IN_OVERFLOW)
+ Rearrange();
+
return true;
}

Powered by Google App Engine
This is Rietveld 408576698