Add test cases for panel overflow handling.

chrome/browser/ui/panels/panel_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
-#include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/download/download_service.h"
 #include "chrome/browser/download/download_service_factory.h"
 #include "chrome/browser/net/url_request_mock_util.h"
 #include "chrome/browser/notifications/balloon_collection_impl.h"
 #include "chrome/browser/notifications/desktop_notification_service.h"
 #include "chrome/browser/notifications/notification.h"
 #include "chrome/browser/notifications/notification_ui_manager.h"
 #include "chrome/browser/prefs/browser_prefs.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h"
 #include "chrome/browser/ui/app_modal_dialogs/native_app_modal_dialog.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/find_bar/find_bar.h"
 #include "chrome/browser/ui/find_bar/find_bar_controller.h"
 #include "chrome/browser/ui/panels/base_panel_browser_test.h"
 #include "chrome/browser/ui/panels/native_panel.h"
 #include "chrome/browser/ui/panels/panel.h"
 #include "chrome/browser/ui/panels/panel_manager.h"
-#include "chrome/browser/ui/panels/panel_overflow_strip.h"
 #include "chrome/browser/ui/panels/panel_settings_menu_model.h"
 #include "chrome/browser/ui/panels/panel_strip.h"
 #include "chrome/browser/ui/panels/test_panel_mouse_watcher.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/browser/download/download_manager.h"
 #include "content/browser/net/url_request_mock_http_job.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/common/show_desktop_notification_params.h"
 #include "content/public/common/url_constants.h"
 #include "net/base/net_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gfx/screen.h"
 
 using content::BrowserThread;
 
 class PanelBrowserTest : public BasePanelBrowserTest {
  public:
   PanelBrowserTest() : BasePanelBrowserTest() {
   }
 
  protected:
-  void CloseWindowAndWait(Browser* browser) {
-    // Closing a browser window may involve several async tasks. Need to use
-    // message pump and wait for the notification.
-    size_t browser_count = BrowserList::size();
-    ui_test_utils::WindowedNotificationObserver signal(
-        chrome::NOTIFICATION_BROWSER_CLOSED,
-        content::Source<Browser>(browser));
-    browser->CloseWindow();
-    signal.Wait();
-    // Now we have one less browser instance.
-    EXPECT_EQ(browser_count - 1, BrowserList::size());
-  }
-
-  void MoveMouse(const gfx::Point& position) {
-    PanelManager::GetInstance()->mouse_watcher()->NotifyMouseMovement(position);
-    MessageLoopForUI::current()->RunAllPending();
-  }
-
   void MoveMouseAndWaitForExpansionStateChange(Panel* panel,
                                                const gfx::Point& position) {
     ui_test_utils::WindowedNotificationObserver signal(
         chrome::NOTIFICATION_PANEL_CHANGED_EXPANSION_STATE,
         content::Source<Panel>(panel));
     MoveMouse(position);
     signal.Wait();
   }
 
-  void TestCreatePanelOnOverflow() {
-    PanelManager* panel_manager = PanelManager::GetInstance();
-    PanelStrip* panel_strip = panel_manager->panel_strip();
-    PanelOverflowStrip* panel_overflow_strip =
-        panel_manager->panel_overflow_strip();
-    EXPECT_EQ(0, panel_manager->num_panels()); // No panels initially.
-
-    // Create testing extensions.
-    DictionaryValue empty_value;
-    scoped_refptr<Extension> extension1 =
-        CreateExtension(FILE_PATH_LITERAL("extension1"),
-        Extension::INVALID, empty_value);
-    scoped_refptr<Extension> extension2 =
-        CreateExtension(FILE_PATH_LITERAL("extension2"),
-        Extension::INVALID, empty_value);
-    scoped_refptr<Extension> extension3 =
-        CreateExtension(FILE_PATH_LITERAL("extension3"),
-        Extension::INVALID, empty_value);
-
-    // First, create 3 panels.
-    Panel* panel1 = CreatePanelWithBounds(
-        web_app::GenerateApplicationNameFromExtensionId(extension1->id()),
-        gfx::Rect(0, 0, 250, 200));
-    Panel* panel2 = CreatePanelWithBounds(
-        web_app::GenerateApplicationNameFromExtensionId(extension2->id()),
-        gfx::Rect(0, 0, 300, 200));
-    Panel* panel3 = CreatePanelWithBounds(
-        web_app::GenerateApplicationNameFromExtensionId(extension1->id()),
-        gfx::Rect(0, 0, 200, 200));
-    ASSERT_EQ(3, panel_manager->num_panels());
-    EXPECT_EQ(3, panel_strip->num_panels());
-    EXPECT_EQ(0, panel_overflow_strip->num_panels());
-
-    // Open a panel that would overflow.
-    CreatePanelParams params4(
-        web_app::GenerateApplicationNameFromExtensionId(extension2->id()),
-        gfx::Rect(0, 0, 280, 200),
-        SHOW_AS_INACTIVE);
-    Panel* panel4 = CreatePanelWithParams(params4);
-    WaitForExpansionStateChanged(panel4, Panel::IN_OVERFLOW);
-    ASSERT_EQ(4, panel_manager->num_panels());
-    EXPECT_EQ(3, panel_strip->num_panels());
-    EXPECT_EQ(1, panel_overflow_strip->num_panels());
-
-    // Open another panel that would overflow.
-    CreatePanelParams params5(
-        web_app::GenerateApplicationNameFromExtensionId(extension3->id()),
-        gfx::Rect(0, 0, 300, 200),
-        SHOW_AS_INACTIVE);
-    Panel* panel5 = CreatePanelWithParams(params5);
-    WaitForExpansionStateChanged(panel5, Panel::IN_OVERFLOW);
-    ASSERT_EQ(5, panel_manager->num_panels());
-    EXPECT_EQ(3, panel_strip->num_panels());
-    EXPECT_EQ(2, panel_overflow_strip->num_panels());
-    EXPECT_EQ(Panel::IN_OVERFLOW, panel4->expansion_state());
-
-    // Close a visible panel. Expect an overflow panel to move over.
-    CloseWindowAndWait(panel2->browser());
-    ASSERT_EQ(4, panel_manager->num_panels());
-    EXPECT_EQ(3, panel_strip->num_panels());
-    EXPECT_EQ(1, panel_overflow_strip->num_panels());
-    EXPECT_NE(Panel::IN_OVERFLOW, panel4->expansion_state());
-    EXPECT_EQ(Panel::IN_OVERFLOW, panel5->expansion_state());
-
-    // Close another visible panel. Remaining overflow panel cannot move over
-    // due to not enough room.
-    CloseWindowAndWait(panel3->browser());
-    ASSERT_EQ(3, panel_manager->num_panels());
-    EXPECT_EQ(2, panel_strip->num_panels());
-    EXPECT_EQ(1, panel_overflow_strip->num_panels());
-    EXPECT_EQ(Panel::IN_OVERFLOW, panel5->expansion_state());
-
-    // Closing one more panel makes room for all panels to fit on screen.
-    CloseWindowAndWait(panel4->browser());
-    ASSERT_EQ(2, panel_manager->num_panels());
-    EXPECT_EQ(2, panel_strip->num_panels());
-    EXPECT_EQ(0, panel_overflow_strip->num_panels());
-    EXPECT_NE(Panel::IN_OVERFLOW, panel5->expansion_state());
-
-    panel1->Close();
-    panel5->Close();
-  }
-
   // Helper function for debugging.
   void PrintAllPanelBounds() {
     const std::vector<Panel*>& panels = PanelManager::GetInstance()->panels();
     DLOG(WARNING) << "PanelBounds:";
     for (size_t i = 0; i < panels.size(); ++i) {
       DLOG(WARNING) << "#=" << i
                     << ", ptr=" << panels[i]
                     << ", x=" << panels[i]->GetBounds().x()
                     << ", y=" << panels[i]->GetBounds().y()
                     << ", width=" << panels[i]->GetBounds().width()
@@ skipping 362 matching lines @@
 IN_PROC_BROWSER_TEST_F(PanelBrowserTest, FindBar) {
   Panel* panel = CreatePanelWithBounds("PanelTest", gfx::Rect(0, 0, 400, 400));
   Browser* browser = panel->browser();
   // FindBar needs tab contents.
   CreateTestTabContents(browser);
   browser->ShowFindBar();
   ASSERT_TRUE(browser->GetFindBarController()->find_bar()->IsFindBarVisible());
   panel->Close();
 }
 
-// TODO(jianli): remove the guard when overflow support is enabled on other
-// platforms. http://crbug.com/105073
-#if defined(OS_WIN)
-#define MAYBE_CreatePanelOnOverflow CreatePanelOnOverflow
-#else
-#define MAYBE_CreatePanelOnOverflow DISABLED_CreatePanelOnOverflow
-#endif
-IN_PROC_BROWSER_TEST_F(PanelBrowserTest, MAYBE_CreatePanelOnOverflow) {
-  TestCreatePanelOnOverflow();
-}
-
 IN_PROC_BROWSER_TEST_F(PanelBrowserTest, DragOnePanel) {
   static const int num_panels = 1;
   static const int zero_delta = 0;
   static const int big_delta = 70;
 
   static const std::vector<int> zero_deltas(num_panels, zero_delta);
   std::vector<int> expected_delta_x_after_drag(num_panels, zero_delta);
   std::vector<int> expected_delta_x_after_finish(num_panels, zero_delta);
 
   Panel* panel1 =
@@ skipping 557 matching lines @@
 #else
 #define MAYBE_ActivateDeactivateMultiple DISABLED_ActivateDeactivateMultiple
 #endif
 
 IN_PROC_BROWSER_TEST_F(PanelBrowserTest, MAYBE_ActivateDeactivateMultiple) {
   BrowserWindow* tabbed_window = BrowserList::GetLastActive()->window();
 
   // Create 4 panels in the following screen layout:
   //    P3  P2  P1  P0
   const int kNumPanels = 4;
-  std::string panel_name_base("PanelTest");
-  for (int i = 0; i < kNumPanels; ++i) {
-    CreatePanelWithBounds(panel_name_base + base::IntToString(i),
-                          gfx::Rect(0, 0, 100, 100));
-  }
+  for (int i = 0; i < kNumPanels; ++i)
+    CreatePanelWithBounds(MakePanelName(i), gfx::Rect(0, 0, 100, 100));
   const std::vector<Panel*>& panels = PanelManager::GetInstance()->panels();
 
   std::vector<bool> expected_active_states;
   std::vector<bool> last_active_states;
 
   // The last created panel, P3, should be active.
   expected_active_states = ProduceExpectedActiveStates(3);
   EXPECT_EQ(expected_active_states, GetAllPanelActiveStates());
   EXPECT_FALSE(tabbed_window->IsActive());
 
@@ skipping 829 matching lines @@
   // position when tall panel brings up its titlebar.
   CloseWindowAndWait(panel1->browser());
   EXPECT_EQ(balloon_bottom_after_tall_panel_titlebar_up,
             GetBalloonBottomPosition(balloon));
 
   // Closing the remaining tall panel should move the notification balloon back
   // to its original position.
   CloseWindowAndWait(panel2->browser());
   EXPECT_EQ(original_balloon_bottom, GetBalloonBottomPosition(balloon));
 }