Add test cases for panel overflow handling.

chrome/browser/ui/panels/base_panel_browser_test.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/base_panel_browser_test.h"
 
 #include "chrome/browser/ui/browser_list.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
+#include "base/string_number_conversions.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/panels/native_panel.h"
 #include "chrome/browser/ui/panels/panel_manager.h"
+#include "chrome/browser/ui/panels/panel_mouse_watcher.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/string_ordinal.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/browser/tab_contents/test_tab_contents.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/common/url_constants.h"
 
 #if defined(OS_MACOSX)
@@ skipping 116 matching lines @@
     AutoHidingDesktopBar::Alignment alignment,
     AutoHidingDesktopBar::Visibility visibility) {
   observer_->OnAutoHidingDesktopBarVisibilityChanged(alignment, visibility);
 }
 
 void MockAutoHidingDesktopBarImpl::NotifyThicknessChange() {
   observer_->OnAutoHidingDesktopBarThicknessChanged();
 }
 
 bool ExistsPanel(Panel* panel) {
-  const PanelManager::Panels& panels = PanelManager::GetInstance()->panels();
+  std::vector<Panel*> panels = PanelManager::GetInstance()->panels();
   return find(panels.begin(), panels.end(), panel) != panels.end();
 }
 
 }  // namespace
 
 const FilePath::CharType* BasePanelBrowserTest::kTestDir =
     FILE_PATH_LITERAL("panels");
 
 BasePanelBrowserTest::BasePanelBrowserTest()
     : InProcessBrowserTest(),
@@ skipping 152 matching lines @@
       MessageLoopForUI::current()->RunAllPending();
       // Restore focus where it was. It will deactivate the new panel.
       last_active_browser->window()->Activate();
     } else {
       panel->ShowInactive();
     }
 #else
     panel->ShowInactive();
 #endif
   }
-  MessageLoopForUI::current()->RunAllPending();
-  // More waiting, because gaining or losing focus may require inter-process
-  // asynchronous communication, and it is not enough to just run the local
-  // message loop to make sure this activity has completed.
-  WaitForPanelActiveState(panel, params.show_flag);
 
-  // On Linux, window size is not available right away and we should wait
-  // before moving forward with the test.
-  WaitForWindowSizeAvailable(panel);
+  if (params.wait_for_fully_created) {
+    MessageLoopForUI::current()->RunAllPending();
+    // More waiting, because gaining or losing focus may require inter-process
+    // asynchronous communication, and it is not enough to just run the local
+    // message loop to make sure this activity has completed.
+    WaitForPanelActiveState(panel, params.show_flag);
 
-  // Wait for the bounds animations on creation to finish.
-  WaitForBoundsAnimationFinished(panel);
+    // On Linux, window size is not available right away and we should wait
+    // before moving forward with the test.
+    WaitForWindowSizeAvailable(panel);
+
+    // Wait for the bounds animations on creation to finish.
+    WaitForBoundsAnimationFinished(panel);
+  }
 
   return panel;
 }
 
 Panel* BasePanelBrowserTest::CreatePanelWithBounds(
     const std::string& panel_name, const gfx::Rect& bounds) {
   CreatePanelParams params(panel_name, bounds, SHOW_AS_ACTIVE);
   return CreatePanelWithParams(params);
 }
 
@@ skipping 26 matching lines @@
   std::string error;
   scoped_refptr<Extension> extension = Extension::Create(
       full_path,  location, *input_value,
       Extension::STRICT_ERROR_CHECKS, &error);
   EXPECT_TRUE(extension.get());
   EXPECT_STREQ("", error.c_str());
   browser()->GetProfile()->GetExtensionService()->
       OnExtensionInstalled(extension.get(), false, StringOrdinal());
   return extension;
 }
+
+void BasePanelBrowserTest::CloseWindowAndWait(Browser* browser) {
+  // Closing a browser window may involve several async tasks. Need to use
+  // message pump and wait for the notification.
+  size_t browser_count = BrowserList::size();
+  ui_test_utils::WindowedNotificationObserver signal(
+      chrome::NOTIFICATION_BROWSER_CLOSED,
+      content::Source<Browser>(browser));
+  browser->CloseWindow();
+  signal.Wait();
+  // Now we have one less browser instance.
+  EXPECT_EQ(browser_count - 1, BrowserList::size());
+}
+
+void BasePanelBrowserTest::MoveMouse(const gfx::Point& position) {
+  PanelManager::GetInstance()->mouse_watcher()->NotifyMouseMovement(position);
+}
+
+std::string BasePanelBrowserTest::MakePanelName(int index) {
+  std::string panel_name("Panel");
+  return panel_name + base::IntToString(index);
+}