Add test cases for panel overflow handling.

chrome/browser/notifications/balloon_collection_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/balloon_collection_impl.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/stl_util.h"
 #include "chrome/browser/notifications/balloon.h"
 #include "chrome/browser/notifications/balloon_host.h"
 #include "chrome/browser/notifications/notification.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/panels/panel.h"
 #include "chrome/browser/ui/panels/panel_manager.h"
+#include "chrome/browser/ui/panels/panel_strip.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/notification_service.h"
 #include "ui/gfx/rect.h"
 #include "ui/gfx/screen.h"
 #include "ui/gfx/size.h"
 
 namespace {
 
 // Portion of the screen allotted for notifications. When notification balloons
@@ skipping 366 matching lines @@
   // restrict to the min & max sizes
   return gfx::Size(
       std::max(min_balloon_width(),
                std::min(max_balloon_width(), size.width())),
       std::max(min_balloon_height(),
                std::min(max_balloon_height(), size.height())));
 }
 
 bool BalloonCollectionImpl::Layout::ComputeOffsetToMoveAbovePanels(
     const gfx::Rect& panel_bounds) {
-  const PanelManager::Panels& panels = PanelManager::GetInstance()->panels();
+  const PanelManager::Panels& panels =

[jennb, 2011/12/08 23:52:00]

Use std::<vector> instead?

[jianli, 2011/12/09 22:39:07]

Done.

+      PanelManager::GetInstance()->panel_strip()->panels();

[jennb, 2011/12/08 23:52:00]

Any way to get all panels and look for any panels whose bounds overlap balloons
to reposition the balloons? Balloons need to avoid overflow panels too. 
Probably needs to be reworked in a separate patch.

[jianli, 2011/12/09 22:39:07]

I will rework on balloon interaction with overflow panels in a separate patch.

   int offset_to_move_above_panels = 0;
 
   // The offset is the maximum height of panels that could overlap with the
   // balloons.
   if (NeedToMoveAboveLeftSidePanels()) {
     // If the affecting panel does not lie in the balloon area, no need to
     // update the offset.
     if (!panel_bounds.IsEmpty() &&
         (panel_bounds.right() <= work_area_.x() ||
          panel_bounds.x() >= work_area_.x() + max_balloon_width())) {
@@ skipping 55 matching lines @@
   gfx::Rect new_work_area = gfx::Screen::GetPrimaryMonitorWorkArea();
 #endif
   if (!work_area_.Equals(new_work_area)) {
     work_area_.SetRect(new_work_area.x(), new_work_area.y(),
                        new_work_area.width(), new_work_area.height());
     changed = true;
   }
 
   return changed;
 }