Don't activate TYPE_CONTROL widget

Don't activate TYPE_CONTROL widget

PrintDialog crashes with the focus restore fix http://codereview.chromium.org/8821004 will be fixed with this patch.

BUG=109616
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113744

[Ben Goodger (Google), 2011-12-09 00:21:10]

LGTM

On Thu, Dec 8, 2011 at 4:19 PM, <oshima@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Don't activate TYPE_CONTROL widget
>
> PrintDialog crashes with the focus restore fix
>
http://codereview.chromium.**org/8821004<http://codereview.chromium.org/88210...
be fixed with this patch.
>
> BUG=109616
> TEST=none
>
>
> Please review this at
http://codereview.chromium.**org/8872043/<http://codereview.chromium.org/8872...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ui/views/widget/widget.cc
>
>
> Index: ui/views/widget/widget.cc
> diff --git a/ui/views/widget/widget.cc b/ui/views/widget/widget.cc
> index 472e284f049ac27602741b7d9a41ca**a7d3c4769d..**
> b186728d9a2d024897c1bf6a2f88b8**b6ecdbc0da 100644
> --- a/ui/views/widget/widget.cc
> +++ b/ui/views/widget/widget.cc
> @@ -133,7 +133,8 @@ Widget::InitParams::**InitParams(Type type)
>       transient(type == TYPE_BUBBLE || type == TYPE_POPUP || type ==
> TYPE_MENU),
>       transparent(false),
>       accept_events(true),
> -      can_activate(type != TYPE_POPUP && type != TYPE_MENU),
> +      can_activate(
> +          type != TYPE_POPUP && type != TYPE_MENU && type !=
> TYPE_CONTROL),
>       keep_on_top(type == TYPE_MENU),
>       ownership(NATIVE_WIDGET_OWNS_**WIDGET),
>       mirror_origin_in_rtl(false),
>
>
>

[commit-bot: I haz the power, 2011-12-09 00:33:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/8872043/2001

[commit-bot: I haz the power, 2011-12-09 01:49:59]

Try job failure for 8872043-2001 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...