Issue 8872038: Remove custom Task implementation from RenderWidgetHelper::UpdateMsgProxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8872038: Remove custom Task implementation from RenderWidgetHelper::UpdateMsgProxy. (Closed)

Created:
9 years ago by dcheng

Modified:
9 years ago

Reviewers:
brettw

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove custom Task implementation from RenderWidgetHelper::UpdateMsgProxy. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113930

Patch Set 2 : Update comment. #

Total comments: 1

Patch Set 3 : Address comments #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -30 lines)			Patch
	M	content/browser/renderer_host/render_widget_helper.cc	View	1 2	6 chunks	+40 lines, -30 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

lgtm http://codereview.chromium.org/8872038/diff/1003/content/browser/renderer_host/render_widget_helper.cc File content/browser/renderer_host/render_widget_helper.cc (right): http://codereview.chromium.org/8872038/diff/1003/content/browser/renderer_host/render_widget_helper.cc#newcode40 content/browser/renderer_host/render_widget_helper.cc:40: : helper_(h), message_(m), cancelled_(false) { Initializers should go ...

9 years ago (2011-12-10 00:01:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/8872038/5001

9 years ago (2011-12-10 00:49:59 UTC) #3

Change committed as 113930