Profiles: Move NetworkActionPredictor to the ProfileKeyedService framework.

chrome/browser/profiles/profile_dependency_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_dependency_manager.h"
 
 #include <algorithm>
 #include <deque>
 #include <iterator>
 
+#include "chrome/browser/autocomplete/network_action_predictor_factory.h"
 #include "chrome/browser/autofill/personal_data_manager_factory.h"
 #include "chrome/browser/background/background_contents_service_factory.h"
 #include "chrome/browser/content_settings/cookie_settings.h"
 #include "chrome/browser/plugin_prefs_factory.h"
 #include "chrome/browser/prerender/prerender_manager_factory.h"
 #include "chrome/browser/printing/cloud_print/cloud_print_proxy_service_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_keyed_service.h"
 #include "chrome/browser/profiles/profile_keyed_service_factory.h"
 #include "chrome/browser/search_engines/template_url_service_factory.h"
@@ skipping 14 matching lines @@
 // creation message to the services that want to create their services at
 // profile creation time.
 //
 // TODO(erg): This needs to be something else. I don't think putting every
 // FooServiceFactory here will scale or is desireable long term.
 void AssertFactoriesBuilt() {
   if (!g_initialized) {
     BackgroundContentsServiceFactory::GetInstance();
     CloudPrintProxyServiceFactory::GetInstance();
     CookieSettings::Factory::GetInstance();
-    SpeechInputExtensionManager::InitializeFactory();
+    NetworkActionPredictorFactory::GetInstance();

[dominich, 2011/12/12 18:25:01]

As this is the only place GetInstance is called, and it's actually used to
initialize the factory, should it be called Initialize instead?

[Elliot Glaysher, 2011/12/12 18:43:47]

This isn't the only place it's used. It's used from the GetForProfile() accessor
and, if anything ever depends on NetworkActionPredictorFactory being created
first, it will be called from a DependsOn() line.

SpeechInputExtensionManager::InitializeFactory() is wrong.

     PersonalDataManagerFactory::GetInstance();
     PluginPrefsFactory::GetInstance();
     prerender::PrerenderManagerFactory::GetInstance();
     SessionServiceFactory::GetInstance();
+    SpeechInputExtensionManager::InitializeFactory();
     TabRestoreServiceFactory::GetInstance();
     TemplateURLServiceFactory::GetInstance();
 
     g_initialized = true;
   }
 }
 
 }  // namespace
 
 void ProfileDependencyManager::AddComponent(
@@ skipping 146 matching lines @@
     }
   }
 
   if (edges.size()) {
     NOTREACHED() << "Dependency graph has a cycle. We are doomed.";
   }
 
   std::reverse(output.begin(), output.end());
   destruction_order_ = output;
 }