Profiles: Move NetworkActionPredictor to the ProfileKeyedService framework.

chrome/browser/autocomplete/network_action_predictor_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/network_action_predictor.h"
 
 #include "base/command_line.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop.h"
 #include "base/string_util.h"
@@ skipping 68 matching lines @@
 class NetworkActionPredictorTest : public testing::Test {
  public:
   NetworkActionPredictorTest()
       : loop_(MessageLoop::TYPE_DEFAULT),
         ui_thread_(BrowserThread::UI, &loop_),
         db_thread_(BrowserThread::DB, &loop_),
         file_thread_(BrowserThread::FILE, &loop_),
         predictor_(new NetworkActionPredictor(&profile_)) {
   }
 
+  virtual ~NetworkActionPredictorTest() {

[dominich, 2011/12/12 18:25:01]

I'm not sure, but I think calling this in TearDown is a better reflection of
normal code flow.

[Elliot Glaysher, 2011/12/12 18:43:47]

Done.

+    predictor_->Shutdown();
+  }
+
   void SetUp() {
     CommandLine::ForCurrentProcess()->AppendSwitchASCII(
         switches::kPrerenderFromOmnibox,
         switches::kPrerenderFromOmniboxSwitchValueEnabled);
 
     ASSERT_TRUE(prerender::GetOmniboxHeuristicToUse() ==
           prerender::OMNIBOX_HEURISTIC_EXACT)
         << "The heuristic has changed so the expectations need to be updated.";
     profile_.CreateHistoryService(true, false);
     profile_.BlockUntilHistoryProcessesPendingRequests();
@@ skipping 261 matching lines @@
         (test_url_db[i].expected_action ==
          NetworkActionPredictor::ACTION_PRERENDER) ?
             NetworkActionPredictor::ACTION_PRECONNECT :
             test_url_db[i].expected_action;
 
     EXPECT_EQ(expected,
               predictor()->RecommendAction(test_url_db[i].user_text, match))
         << "Unexpected action for " << match.destination_url;
   }
 }