Issue 8872031: Fix race condition in extension service that causes extensions installed

Issue 8872031: Fix race condition in extension service that causes extensions installed (Closed)

Created:
9 years ago by Roger Tawa OOO till Jul 10th

Modified:
9 years ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, jstritar+watch_chromium.org, Paweł Hajdan Jr., mihaip+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix race condition in extension service that causes extensions installed concurently with the extension garbage collection to sometimes get marked for deletion. The concurrency is between the extension installation in the browser process and the garbage collection in the import process. BUG=101935 TEST=Install google chrome and look at the default apps installed in the first profile. The icons for all the apps should be correct. This does not work with chromium builds since default apps are not installed there. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114695

Patch Set 1 #

Patch Set 2 : Remove unwanted change from unit tests #

Patch Set 3 : Don't install/garbage extensions in import process #

Total comments: 2

Patch Set 4 : Created tracking bug, update comment #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -5 lines)			Patch
	M	chrome/browser/extensions/extension_service.cc	View	1 2 3	1 chunk	+12 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Roger Tawa OOO till Jul 10th

Hi Aaron, Based on our discussions. Please take a look. Thanks.

9 years ago (2011-12-14 19:40:09 UTC) #2

Aaron Boodman

http://codereview.chromium.org/8872031/diff/13002/chrome/browser/extensions/extension_service.cc File chrome/browser/extensions/extension_service.cc (right): http://codereview.chromium.org/8872031/diff/13002/chrome/browser/extensions/extension_service.cc#newcode558 chrome/browser/extensions/extension_service.cc:558: // that is already running an extension service for ...

9 years ago (2011-12-14 22:19:34 UTC) #3

Roger Tawa OOO till Jul 10th

Thanks Aaron. Please take another look. http://codereview.chromium.org/8872031/diff/13002/chrome/browser/extensions/extension_service.cc File chrome/browser/extensions/extension_service.cc (right): http://codereview.chromium.org/8872031/diff/13002/chrome/browser/extensions/extension_service.cc#newcode558 chrome/browser/extensions/extension_service.cc:558: // that is ...

9 years ago (2011-12-15 00:44:03 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/8872031/19001

9 years ago (2011-12-15 18:35:45 UTC) #6

Change committed as 114695

Expand Messages | Collapse Messages