content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc - Issue 8872030: Removing MessageLoop::QuitTask() from content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc

Issue 8872030: Removing MessageLoop::QuitTask() from content/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix escaping Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/audio_renderer_host_unittest.cc ('k') | content/browser/renderer_host/media/video_capture_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc

diff --git a/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc b/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc

index 6673d2907826663a31ffa320637a81f8b0617230..1a11c9026cf4bf7168b4bf367f1c4f4cb714b40b 100644

--- a/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc

+++ b/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc

@@ -104,7 +104,7 @@ class MockMediaStreamDispatcherHost : public MediaStreamDispatcherHost {

OnStreamGenerated(msg.routing_id(), request_id, audio_device_list.size(),

video_device_list.size());

// Notify that the event have occured.

- message_loop_->PostTask(FROM_HERE, new MessageLoop::QuitTask());

+ message_loop_->PostTask(FROM_HERE, MessageLoop::QuitClosure());

label_ = label;

audio_devices_ = audio_device_list;

video_devices_ = video_device_list;

@@ -112,7 +112,7 @@ class MockMediaStreamDispatcherHost : public MediaStreamDispatcherHost {

void OnStreamGenerationFailed(const IPC::Message& msg, int request_id) {

OnStreamGenerationFailed(msg.routing_id(), request_id);

- message_loop_->PostTask(FROM_HERE, new MessageLoop::QuitTask());

+ message_loop_->PostTask(FROM_HERE, MessageLoop::QuitClosure());

label_= "";

}

@@ -121,7 +121,7 @@ class MockMediaStreamDispatcherHost : public MediaStreamDispatcherHost {

int index) {

OnAudioDeviceFailed(msg.routing_id(), index);

audio_devices_.erase(audio_devices_.begin() + index);

- message_loop_->PostTask(FROM_HERE, new MessageLoop::QuitTask());

+ message_loop_->PostTask(FROM_HERE, MessageLoop::QuitClosure());

}

void OnVideoDeviceFailed(const IPC::Message& msg,

@@ -129,7 +129,7 @@ class MockMediaStreamDispatcherHost : public MediaStreamDispatcherHost {

int index) {

OnVideoDeviceFailed(msg.routing_id(), index);

video_devices_.erase(video_devices_.begin() + index);

- message_loop_->PostTask(FROM_HERE, new MessageLoop::QuitTask());

+ message_loop_->PostTask(FROM_HERE, MessageLoop::QuitClosure());

}

MessageLoop* message_loop_;

@@ -172,7 +172,7 @@ class MediaStreamDispatcherHostTest : public testing::Test {

// Called on the VideoCaptureManager thread.

static void PostQuitMessageLoop(MessageLoop* message_loop) {

- message_loop->PostTask(FROM_HERE, new MessageLoop::QuitTask());

+ message_loop->PostTask(FROM_HERE, MessageLoop::QuitClosure());

}

// Called on the main thread.