Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 8872027: Add bluetooth device list. (Closed)

Created:
9 years ago by kevers
Modified:
8 years, 10 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Add bluetooth device list. BUG=chromium:106442 TEST=

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -0 lines) Patch
A chrome/browser/resources/options/chromeos/bluetooth_device_list.js View 1 1 chunk +232 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kevers
Hi James, Can you please have a look at this CL, which is part of ...
9 years ago (2011-12-08 19:09:42 UTC) #1
James Hawkins
LGTM http://codereview.chromium.org/8872027/diff/1/chrome/browser/resources/options/chromeos/bluetooth_device_list.js File chrome/browser/resources/options/chromeos/bluetooth_device_list.js (right): http://codereview.chromium.org/8872027/diff/1/chrome/browser/resources/options/chromeos/bluetooth_device_list.js#newcode117 chrome/browser/resources/options/chromeos/bluetooth_device_list.js:117: onBlur_: function() { Hmm, I wonder if this ...
9 years ago (2011-12-08 19:18:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/8872027/3001
9 years ago (2011-12-08 19:39:05 UTC) #3
kevers
9 years ago (2011-12-08 19:39:55 UTC) #4
http://codereview.chromium.org/8872027/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/chromeos/bluetooth_device_list.js (right):

http://codereview.chromium.org/8872027/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/chromeos/bluetooth_device_list.js:117: onBlur_:
function() {
On 2011/12/08 19:18:03, James Hawkins wrote:
> Hmm, I wonder if this should be pushed up to the list class...
Added a TODO note.  Certainly worth investigating.

Powered by Google App Engine
This is Rietveld 408576698