Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 8872024: Revert 113606 - Improve RenderTextWin font fallback. (Closed)

Created:
9 years ago by sky
Modified:
9 years ago
CC:
chromium-reviews, tfarina, James Su, yusukes+watch_chromium.org, penghuang+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 113606 - Improve RenderTextWin font fallback. Don't use SCRIPT_UNDEFINED in the case of font fallback, unless font fallback actually fails to return a script that can display the characters. This fixes the problem of some scripts not being properly displayed. This actually makes RenderTextWin properly validate whether a text position accepts a cursor, which caused several tests to fail and revealed some additional issues in RenderTextWin. The CL includes some modifications to address this. Some tests are disabled under XP, see: http://crbug.com/106450 Also, fixes some lint warnings. BUG=90426 TEST=Run chrome.exe --use-pure-views and paste some Bengali text into the omnibox. It should show up properly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113075 Review URL: http://codereview.chromium.org/8575020 TBR=asvitkine@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113613

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -250 lines) Patch
M ui/gfx/render_text.h View 2 chunks +0 lines, -8 lines 0 comments Download
M ui/gfx/render_text.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M ui/gfx/render_text_linux.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gfx/render_text_unittest.cc View 2 chunks +0 lines, -117 lines 0 comments Download
M ui/gfx/render_text_win.cc View 6 chunks +23 lines, -71 lines 0 comments Download
M ui/views/controls/textfield/textfield_views_model_unittest.cc View 7 chunks +40 lines, -45 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sky
9 years ago (2011-12-08 17:31:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698