[cros] Use a distinct icon for the guest session.

[cros] Use a distinct icon for the guest session.


BUG=chromium-os:22840
TEST=Manual: see bug description

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113789

[Ivan Korotkov, 2011-12-08 13:36:01]

PTAL

[whywhat, 2011-12-08 17:21:01]

lgtm

http://codereview.chromium.org/8872015/diff/1/chrome/browser/chromeos/frame/b...
File chrome/browser/chromeos/frame/browser_frame_view_chromeos.cc (right):

http://codereview.chromium.org/8872015/diff/1/chrome/browser/chromeos/frame/b...
chrome/browser/chromeos/frame/browser_frame_view_chromeos.cc:77: if
(!browser_view()->IsOffTheRecord()) {
Is it some debug change? Seems like it should remain as it was

http://codereview.chromium.org/8872015/diff/1/chrome/browser/ui/views/frame/b...
File chrome/browser/ui/views/frame/browser_non_client_frame_view.cc (right):

http://codereview.chromium.org/8872015/diff/1/chrome/browser/ui/views/frame/b...
chrome/browser/ui/views/frame/browser_non_client_frame_view.cc:46:
gfx::Image(new SkBitmap(browser_view_->GetOTRAvatarIcon())), false);
Maybe we should rather change GetOTRAvatarIcon that would return different icons
depending on what session we're in?

[Ivan Korotkov, 2011-12-09 09:38:21]

http://codereview.chromium.org/8872015/diff/1/chrome/browser/chromeos/frame/b...
File chrome/browser/chromeos/frame/browser_frame_view_chromeos.cc (right):

http://codereview.chromium.org/8872015/diff/1/chrome/browser/chromeos/frame/b...
chrome/browser/chromeos/frame/browser_frame_view_chromeos.cc:77: if
(!browser_view()->IsOffTheRecord()) {
On 2011/12/08 17:21:01, whywhat wrote:
> Is it some debug change? Seems like it should remain as it was

Ooops. Thanks for the catch.

http://codereview.chromium.org/8872015/diff/1/chrome/browser/ui/views/frame/b...
File chrome/browser/ui/views/frame/browser_non_client_frame_view.cc (right):

http://codereview.chromium.org/8872015/diff/1/chrome/browser/ui/views/frame/b...
chrome/browser/ui/views/frame/browser_non_client_frame_view.cc:46:
gfx::Image(new SkBitmap(browser_view_->GetOTRAvatarIcon())), false);
On 2011/12/08 17:21:01, whywhat wrote:
> Maybe we should rather change GetOTRAvatarIcon that would return different
icons
> depending on what session we're in?

As discussed offline, better leave it as is.

[commit-bot: I haz the power, 2011-12-09 09:42:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ivankr@chromium.org/8872015/2003