Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 8872001: Refactor generete_bindings.py so per function logging code and be added. (Closed)

Created:
9 years ago by greggman
Modified:
9 years ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, dhollowa+watch_chromium.org
Visibility:
Public.

Description

Refactor generete_bindings.py so per function logging code and be added. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113732

Patch Set 1 #

Patch Set 2 : GPU_ -> GL_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1037 lines, -488 lines) Patch
M ui/gfx/gl/generate_bindings.py View 1 12 chunks +1032 lines, -488 lines 0 comments Download
M ui/gfx/gl/gl_bindings.h View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
greggman
Hey Al, please review. thx.
9 years ago (2011-12-07 23:54:44 UTC) #1
apatrick_chromium
lgtm
9 years ago (2011-12-07 23:59:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/8872001/1
9 years ago (2011-12-08 01:35:16 UTC) #3
commit-bot: I haz the power
Try job failure for 8872001-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-12-08 01:59:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/8872001/5001
9 years ago (2011-12-08 23:24:48 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-09 01:49:59 UTC) #6
Change committed as 113732

Powered by Google App Engine
This is Rietveld 408576698