Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Issue 8870006: Track confidence calculations better. Reduce minimum user text length. (Closed)

Created:
9 years ago by dominich
Modified:
9 years ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Visibility:
Public.

Description

Track confidence calculations better. Reduce minimum user text length. Database sizes are low so it is safe to reduce the minimum user text length. This should increase coverage. To help track potential coverage increases, it is good to remove trivial 0 confidences from the histogram of confidences. BUG=107212, 107213 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114091

Patch Set 1 #

Total comments: 1

Patch Set 2 : More explicit comment #

Patch Set 3 : Update unit test expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -23 lines) Patch
M chrome/browser/autocomplete/network_action_predictor.h View 1 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/network_action_predictor.cc View 4 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/autocomplete/network_action_predictor_unittest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dominich
9 years ago (2011-12-08 00:05:24 UTC) #1
Peter Kasting
LGTM http://codereview.chromium.org/8870006/diff/1/chrome/browser/autocomplete/network_action_predictor.h File chrome/browser/autocomplete/network_action_predictor.h (right): http://codereview.chromium.org/8870006/diff/1/chrome/browser/autocomplete/network_action_predictor.h#newcode145 chrome/browser/autocomplete/network_action_predictor.h:145: // to differentiate trivial zero results from actual ...
9 years ago (2011-12-08 00:10:24 UTC) #2
dominich
Added a new file - PTAL.
9 years ago (2011-12-08 17:54:44 UTC) #3
Peter Kasting
LGTM
9 years ago (2011-12-08 18:29:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominich@chromium.org/8870006/7001
9 years ago (2011-12-09 18:00:43 UTC) #5
commit-bot: I haz the power
Try job failure for 8870006-7001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
9 years ago (2011-12-09 19:57:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominich@chromium.org/8870006/7001
9 years ago (2011-12-12 18:31:41 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-12 21:58:11 UTC) #8
Change committed as 114091

Powered by Google App Engine
This is Rietveld 408576698