Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 8870002: Apply renaming of ppapi shared stuff to new ppb_var shared code. (Closed)

Created:
9 years ago by dmichael (off chromium)
Modified:
9 years ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Apply renaming of ppapi shared stuff to new ppb_var shared code. This CL brings the PPB_Var new shared implementation (from r113491) in to compliance with the new naming convention introduced at r113428. I didn't want to do add any more complexity to that in-flight CL, so I'm doing the rename here. BUG=None TEST=N/A Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113563

Patch Set 1 #

Patch Set 2 : Update unittest #

Patch Set 3 : fix header guard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -134 lines) Patch
M ppapi/ppapi_shared.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_var_deprecated_proxy.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_var_unittest.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
D ppapi/shared_impl/ppb_var_impl.h View 1 chunk +0 lines, -26 lines 0 comments Download
D ppapi/shared_impl/ppb_var_impl.cc View 1 chunk +0 lines, -78 lines 0 comments Download
A + ppapi/shared_impl/ppb_var_shared.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
A + ppapi/shared_impl/ppb_var_shared.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_var_deprecated_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dmichael (off chromium)
Should be a quick and easy review.
9 years ago (2011-12-08 03:37:36 UTC) #1
brettw
lgtm
9 years ago (2011-12-08 03:46:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/8870002/2003
9 years ago (2011-12-08 03:49:00 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-08 04:51:16 UTC) #4
Change committed as 113563

Powered by Google App Engine
This is Rietveld 408576698