Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 8869008: chrome://os-credits "show license" links tripping over CSP restrictions. (Closed)

Created:
9 years ago by Tom Sepez
Modified:
9 years ago
Reviewers:
Daniel Erat, zel, Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

chrome://os-credits "show license" links tripping over CSP restrictions. BUG=chromium-os:23898 TEST=go to chrome://os-credits and click on "show license" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113527

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/webui/chrome_url_data_manager_backend.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Daniel Erat
LGTM. Thanks!
9 years ago (2011-12-08 00:16:52 UTC) #1
Evan Stade
lgtm
9 years ago (2011-12-08 00:45:45 UTC) #2
Tom Sepez
Too many cooks, deferring to http://codereview.chromium.org/8879001/
9 years ago (2011-12-08 00:53:48 UTC) #3
Tom Sepez
Complete about face, landing this, killing http://codereview.chromium.org/8879001/
9 years ago (2011-12-08 01:05:25 UTC) #4
zel
9 years ago (2011-12-08 01:07:02 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698