Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 8869004: Revert 113419 - Revert 113409 - Add a new method to SSLClientSocket: (Closed)

Created:
9 years ago by Ryan Hamilton
Modified:
9 years ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Revert 113419 - Revert 113409 - Add a new method to SSLClientSocket: was_origin_cert_sent() This will help SpdySession decide to send a CREDENTIAL frame. BUG=106103 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113528

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M net/socket/ssl_client_socket.h View 1 chunk +10 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket.cc View 2 chunks +10 lines, -1 line 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Ryan Hamilton
Attempting to reland 113409.
9 years ago (2011-12-07 22:55:09 UTC) #1
wtc
LGTM. http://codereview.chromium.org/8869004/diff/1/net/socket/ssl_client_socket_nss.cc File net/socket/ssl_client_socket_nss.cc (right): http://codereview.chromium.org/8869004/diff/1/net/socket/ssl_client_socket_nss.cc#newcode2279 net/socket/ssl_client_socket_nss.cc:2279: rv = SECFailure; Nit: let's take the opportunity ...
9 years ago (2011-12-07 22:59:58 UTC) #2
Ryan Hamilton
THanks! http://codereview.chromium.org/8869004/diff/1/net/socket/ssl_client_socket_nss.cc File net/socket/ssl_client_socket_nss.cc (right): http://codereview.chromium.org/8869004/diff/1/net/socket/ssl_client_socket_nss.cc#newcode2279 net/socket/ssl_client_socket_nss.cc:2279: rv = SECFailure; On 2011/12/07 22:59:59, wtc wrote: ...
9 years ago (2011-12-07 23:02:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/8869004/3004
9 years ago (2011-12-07 23:03:45 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-08 01:51:42 UTC) #5
Change committed as 113528

Powered by Google App Engine
This is Rietveld 408576698