Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5457)

Unified Diff: chrome/browser/extensions/extension_proxy_api_helpers.cc

Issue 8869003: Move the "extension" namespace from extension_api.json into extension_api_extension.json. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: build.py again? Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_proxy_api_helpers.cc
diff --git a/chrome/browser/extensions/extension_proxy_api_helpers.cc b/chrome/browser/extensions/extension_proxy_api_helpers.cc
index 6a9e14b274e09ebd9bb887a1d803859597b42e6e..3a26a176cc8332be4e6db9490e1c66cc52c2cba9 100644
--- a/chrome/browser/extensions/extension_proxy_api_helpers.cc
+++ b/chrome/browser/extensions/extension_proxy_api_helpers.cc
@@ -64,7 +64,7 @@ bool GetProxyModeFromExtensionPref(const DictionaryValue* proxy_config,
std::string proxy_mode;
// We can safely assume that this is ASCII due to the allowed enumeration
- // values specified in extension_api.json.
+ // values specified in the extension API JSON.
proxy_config->GetStringASCII(keys::kProxyConfigMode, &proxy_mode);
if (!ProxyPrefs::StringToProxyMode(proxy_mode, out)) {
LOG(ERROR) << "Invalid mode for proxy settings: " << proxy_mode;
@@ -154,7 +154,7 @@ bool GetProxyServer(const DictionaryValue* proxy_server,
std::string scheme_string; // optional.
// We can safely assume that this is ASCII due to the allowed enumeration
- // values specified in extension_api.json.
+ // values specified in the extension API JSON.
proxy_server->GetStringASCII(keys::kProxyConfigRuleScheme, &scheme_string);
net::ProxyServer::Scheme scheme =
« no previous file with comments | « chrome/browser/extensions/extension_proxy_api.cc ('k') | chrome/browser/extensions/extension_webnavigation_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698