Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Issue 8869002: Don't show caps lock notification bubble on lock screen. (Closed)

Created:
9 years ago by flackr
Modified:
9 years ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Don't show caps lock notification bubble on lock screen. BUG=105280 TEST=Lock the screen and enable caps lock. No bubble indicators are shown. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114687

Patch Set 1 #

Patch Set 2 : Merge with master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/chromeos/status/caps_lock_menu_button.cc View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
flackr
The underlying issue would require a substantial change. To get a fix in for the ...
9 years ago (2011-12-07 22:44:05 UTC) #1
Nikita (slow)
LGTM I agree that having this notification on screen lock is not essential at this ...
9 years ago (2011-12-08 10:42:13 UTC) #2
Nikita (slow)
lgtm please run trybots
9 years ago (2011-12-08 10:42:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/8869002/1
9 years ago (2011-12-08 15:44:54 UTC) #4
commit-bot: I haz the power
Presubmit check for 8869002-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-08 15:44:57 UTC) #5
flackr
+davemoore Need owner approval, PTAL, thanks!
9 years ago (2011-12-08 18:52:37 UTC) #6
DaveMoore
lgtm On 2011/12/08 18:52:37, flackr wrote: > +davemoore > > Need owner approval, PTAL, thanks!
9 years ago (2011-12-14 17:06:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/8869002/7001
9 years ago (2011-12-15 18:13:02 UTC) #8
commit-bot: I haz the power
9 years ago (2011-12-15 20:01:12 UTC) #9
Change committed as 114687

Powered by Google App Engine
This is Rietveld 408576698