Issue 8869001: Adding new pyauto perf test for an HTML5 benchmark.

LGTM http://codereview.chromium.org/8869001/diff/2001/chrome/test/functional/perf.py File chrome/test/functional/perf.py (right): http://codereview.chromium.org/8869001/diff/2001/chrome/test/functional/perf.py#newcode754 chrome/test/functional/perf.py:754: class HTML5Test(BasePerfTest): Change name to HTML5BenchmarkTest http://codereview.chromium.org/8869001/diff/2001/chrome/test/functional/perf.py#newcode755 chrome/test/functional/perf.py:755: ...

9 years ago (2011-12-07 22:55:22 UTC) #2

dennis_jeffrey

9 years ago (2011-12-07 23:04:46 UTC) #3

Thank you for the review.  There's a conflicting change to this file that is
being run through the CQ right now.  I'm going to wait until that lands before I
manually resolve the conflict and submit this.

http://codereview.chromium.org/8869001/diff/2001/chrome/test/functional/perf.py
File chrome/test/functional/perf.py (right):

http://codereview.chromium.org/8869001/diff/2001/chrome/test/functional/perf....
chrome/test/functional/perf.py:754: class HTML5Test(BasePerfTest):
On 2011/12/07 22:55:22, Nirnimesh wrote:
> Change name to HTML5BenchmarkTest

Done.

http://codereview.chromium.org/8869001/diff/2001/chrome/test/functional/perf....
chrome/test/functional/perf.py:755: """Tests for HTML5 performance."""
On 2011/12/07 22:55:22, Nirnimesh wrote:
> It'd be nice to declare the URL here.

Leaving alone as per offline discussion.  The URL is mentioned in the docstring
for the test below (line 758).

Expand Messages | Collapse Messages

Issue 8869001: Adding new pyauto perf test for an HTML5 benchmark. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Increased timeout since this benchmark can be really slow on ChromeOS. #

Patch Set 3 : Addressed review comment. #

Patch Set 4 : Merged with trunk (required minor edit). #

Messages