Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 8867005: Win AcceleratedSurface no longer polls queries on separate thread. (Closed)

Created:
9 years ago by apatrick_chromium
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Win AcceleratedSurface no longer polls queries on separate thread. This is basically a reversion of the final patch set (#4) of this: http://codereview.chromium.org/8395012 The reason is because tasks posted to the query thread can extend the lifetime of the D3D device such that it is destroyed on the query thread. The D3D thread must be destroyed on the thread it was created on though. The suggestion was a good one and I might revisit it in the future. I also added a missing lock and switched it to load the D3D9 DLL rather than assume it is already loaded by something else. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113529

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -162 lines) Patch
M ui/gfx/surface/accelerated_surface_win.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/gfx/surface/accelerated_surface_win.cc View 10 chunks +28 lines, -162 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
apatrick_chromium
9 years ago (2011-12-07 23:43:39 UTC) #1
jbauman
lgtm
9 years ago (2011-12-07 23:46:00 UTC) #2
apatrick_chromium
+kbr
9 years ago (2011-12-08 01:49:43 UTC) #3
Ken Russell (switch to Gerrit)
9 years ago (2011-12-08 01:55:07 UTC) #4
LGTM; seems much simpler.

http://codereview.chromium.org/8867005/diff/1/ui/gfx/surface/accelerated_surf...
File ui/gfx/surface/accelerated_surface_win.cc (right):

http://codereview.chromium.org/8867005/diff/1/ui/gfx/surface/accelerated_surf...
ui/gfx/surface/accelerated_surface_win.cc:373: } while (hr == S_FALSE);
As an FYI a problem in a similarly structured loop was reported in
http://code.google.com/p/angleproject/issues/detail?id=262 .

Powered by Google App Engine
This is Rietveld 408576698