Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 8866009: Mark dbus EndToEndAsyncTest.TestSignalFromRoot flaky (Closed)

Created:
9 years ago by arthurhsu
Modified:
9 years ago
Reviewers:
Raghu Simha
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Mark dbus EndToEndAsyncTest.TestSignalFromRoot flaky BUG=106796 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113516

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update per code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M dbus/end_to_end_async_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
arthurhsu
9 years ago (2011-12-08 00:40:52 UTC) #1
Raghu Simha
LGTM with one nit.
9 years ago (2011-12-08 00:51:39 UTC) #2
Raghu Simha
9 years ago (2011-12-08 00:51:59 UTC) #3
http://codereview.chromium.org/8866009/diff/1/dbus/end_to_end_async_unittest.cc
File dbus/end_to_end_async_unittest.cc (right):

http://codereview.chromium.org/8866009/diff/1/dbus/end_to_end_async_unittest....
dbus/end_to_end_async_unittest.cc:297: 
nit: Add an annotation to the bug ID with a TODO.

Powered by Google App Engine
This is Rietveld 408576698