Issue 8866005: GTK: Speculative fix for crash in PluginInfoBarDelegate::Cancel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8866005: GTK: Speculative fix for crash in PluginInfoBarDelegate::Cancel. (Closed)

Created:
9 years ago by Elliot Glaysher

Modified:
9 years ago

Reviewers:
Peter Kasting

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

GTK: Speculative fix for crash in PluginInfoBarDelegate::Cancel. Speculation is that the signal isn't using our autoexpiring Signals(). BUG=106768 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113549

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	chrome/browser/ui/gtk/infobars/confirm_infobar_gtk.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8866005/1

9 years ago (2011-12-07 23:01:10 UTC) #3

commit-bot: I haz the power

Try job failure for 8866005-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...

9 years ago (2011-12-08 01:00:51 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8866005/1

9 years ago (2011-12-08 01:03:09 UTC) #5

Change committed as 113549