Issue 8866002: GTK: Stamp out GtkThemeService::GetSurfaceNamed().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8866002: GTK: Stamp out GtkThemeService::GetSurfaceNamed(). (Closed)

Created:
9 years ago by Elliot Glaysher

Modified:
9 years ago

Reviewers:
Lei Zhang

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

GTK: Stamp out GtkThemeService::GetSurfaceNamed(). This replaces all calls to GetSurfaceNamed with GetImageNamed if the image is theme dependent, or with calls to ResourceBundle if the image can be shared across Profiles. BUG=106060 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113724

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -64 lines)			Patch
M	chrome/browser/ui/gtk/browser_window_gtk.cc	View	8 chunks	+26 lines, -26 lines	0 comments	Download
M	chrome/browser/ui/gtk/find_bar_gtk.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_theme_service.h	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_theme_service.cc	View	2 chunks	+0 lines, -19 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_util.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8866002/1

9 years ago (2011-12-08 23:09:38 UTC) #3

Change committed as 113724

Expand Messages | Collapse Messages