ppapi/native_client/src/shared/ppapi_proxy/ppb_graphics_3d.srpc - Issue 8865008: Revert 113479 - Revert "Revert 113250 - Add CommandBuffer::SetGetBuffer"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/shared/ppapi_proxy/ppb_graphics_3d.srpc

Issue 8865008: Revert 113479 - Revert "Revert 113250 - Add CommandBuffer::SetGetBuffer" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.cc ('k') | ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/native_client/src/shared/ppapi_proxy/ppb_graphics_3d.srpc

===================================================================

--- ppapi/native_client/src/shared/ppapi_proxy/ppb_graphics_3d.srpc (revision 113511)

+++ ppapi/native_client/src/shared/ppapi_proxy/ppb_graphics_3d.srpc (working copy)

@@ -77,15 +77,16 @@

# Initialize the command buffer.

{'name': 'PPB_Graphics3DTrusted_InitCommandBuffer',

'inputs': [['resource_id', 'PP_Resource'],

+ ['size', 'int32_t']

'outputs': [['success', 'int32_t']] # PP_Bool

- # Set the buffer used for commands.

- {'name': 'PPB_Graphics3DTrusted_SetGetBuffer',

- 'inputs': [['resource_id', 'PP_Resource'],

- ['shm_id', 'int32_t'],

- ],

- 'outputs': []

+ # Get the ring buffer.

+ {'name': 'PPB_Graphics3DTrusted_GetRingBuffer',

+ 'inputs': [['resource_id', 'PP_Resource']],

+ 'outputs': [['shm_desc', 'handle'],

+ ['shm_size', 'int32_t']

+ ]

# Get command buffer state.

{'name': 'PPB_Graphics3DTrusted_GetState',

@@ -141,6 +142,6 @@

['shm_size', 'int32_t']

]

- # End of PPB_Graphics3DTrusted

+ # End of PPB_Graphics3DTrusted

]

}