The chromoting client logs connection statistics to the server.

remoting/webapp/me2mom/debug_log.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Module to support logging debug messages.
  */
 
 'use strict';
@@ skipping 72 matching lines @@
     debugLog.hidden = true;
   }
 };
 
 /**
  * Update the statistics panel.
  * @param {Object.<string, number>} stats The connection statistics.
  */
 remoting.DebugLog.prototype.updateStatistics = function(stats) {
   var units = '';
-  var videoBandwidth = stats['video_bandwidth'];
+  var videoBandwidth = stats[remoting.ClientSession.STATS_KEY_VIDEO_BANDWIDTH];
   if (videoBandwidth < 1024) {
     units = 'Bps';
   } else if (videoBandwidth < 1048576) {
     units = 'KiBps';
     videoBandwidth = videoBandwidth / 1024;
   } else if (videoBandwidth < 1073741824) {
     units = 'MiBps';
     videoBandwidth = videoBandwidth / 1048576;
   } else {
     units = 'GiBps';
     videoBandwidth = videoBandwidth / 1073741824;
   }
 
   var statistics = document.getElementById('statistics');
   this.statsElement.innerText =
       'Bandwidth: ' + videoBandwidth.toFixed(2) + units +
       ', Frame Rate: ' +
-          (stats['video_frame_rate'] ?
-           stats['video_frame_rate'].toFixed(2) + ' fps' : 'n/a') +
-      ', Capture: ' + stats['capture_latency'].toFixed(2) + 'ms' +
-      ', Encode: ' + stats['encode_latency'].toFixed(2) + 'ms' +
-      ', Decode: ' + stats['decode_latency'].toFixed(2) + 'ms' +
-      ', Render: ' + stats['render_latency'].toFixed(2) + 'ms' +
-      ', Latency: ' + stats['roundtrip_latency'].toFixed(2) + 'ms';
+          (stats[remoting.ClientSession.STATS_KEY_VIDEO_FRAME_RATE] ?
+           stats[remoting.ClientSession.STATS_KEY_VIDEO_FRAME_RATE].toFixed(2)
+              + ' fps' : 'n/a') +
+      ', Capture: ' +
+      stats[remoting.ClientSession.STATS_KEY_CAPTURE_LATENCY].toFixed(2) +
+      'ms' +
+      ', Encode: ' +
+      stats[remoting.ClientSession.STATS_KEY_ENCODE_LATENCY].toFixed(2) +
+      'ms' +
+      ', Decode: ' +
+      stats[remoting.ClientSession.STATS_KEY_DECODE_LATENCY].toFixed(2) +
+      'ms' +
+      ', Render: ' +
+      stats[remoting.ClientSession.STATS_KEY_RENDER_LATENCY].toFixed(2) +
+      'ms' +
+      ', Latency: ' +
+      stats[remoting.ClientSession.STATS_KEY_ROUNDTRIP_LATENCY].toFixed(2) +
+      'ms';
 };
 
 /**
  * Check for the debug toggle hot-key.
  *
  * @param {Event} event The keyboard event.
  * @return {void} Nothing.
  */
 remoting.DebugLog.onKeydown = function(event) {
   var element = /** @type {Element} */ (event.target);
@@ skipping 517 matching lines @@
             return false;
           }
           var type = session.getAttribute('type');
           if (type != 'initiate') {
             return false;
           }
           // Silently ignore contents of 'session' node.
           return true;
         }
       }
-    } else if (child.nodeName == 'gr:log') {

[Jamie, 2011/12/09 19:47:56]

Has this code really all gone, or does it still exist elsewhere?

[simonmorris, 2011/12/09 21:12:12]

All gone, as requested in the previous review.
There's no need for this code to handle logging stanzas
when the logging code is printing them itself.

-      var log = child;
-      if (log.childNodes.length != 1) {
-        return false;
-      }
-      if (!this.verifyAttributes(log, 'xmlns:gr')) {
-        return false;
-      }
-
-      /** @type {Node} */
-      var entry = log.childNodes[0];
-      if (!this.verifyAttributes(entry, 'role,event-name,session-state,cpu,' +
-                                 'os-name,browser-version,webapp-version,id')) {
-        return false;
-      }
-      var role = entry.getAttribute('role');
-      if (role != 'client') {
-        return false;
-      }
-      var event_name = entry.getAttribute('event-name');
-      if (event_name != 'session-state') {
-        return false;
-      }
-      var session_state = entry.getAttribute('session-state');
-      this.prettyIqHeading(action, '?', 'log session-state ' + session_state,
-                           null);
-
-      var os_name = entry.getAttribute('os-name');
-      var cpu = entry.getAttribute('cpu');
-      var browser_version = entry.getAttribute('browser-version');
-      var webapp_version = entry.getAttribute('webapp-version');
-      this.logIndent(1, os_name + ' ' + cpu + ' Chromium_v' + browser_version +
-                     ' Chromoting_v' + webapp_version);
-      var remoting_id = entry.getAttribute('id');
-      if (remoting_id) {
-        this.logIndent(1, 'id: ' + remoting_id);
-      }
-      return true;
     }
   }
   return false;
-}
+};
 
 /**
  * Print out an iq 'error'-type node.
  *
  * @param {string} action String describing action (send/receive).
  * @param {NodeList} iq_list Node containing the 'error' xml.
  *
  * @return {boolean} True if the data was logged successfully.
  */
 remoting.DebugLog.prototype.prettyIqError = function(action, iq_list) {
@@ skipping 112 matching lines @@
 remoting.DebugLog.prototype.logIq = function(send, message) {
   if (!this.prettyIq(send, message)) {
     // Fall back to showing the raw stanza.
     var prefix = (send ? 'Sending Iq: ' : 'Receiving Iq: ');
     this.log(prefix + message);
   }
 };
 
 /** @type {remoting.DebugLog} */
 remoting.debug = null;