Mark WebNavigation tests as using legacy extension manifests.

Mark WebNavigation tests as using legacy extension manifests.

We could convert these tests to use manifest_version 2, but it's not worth the
effort.  (After this patch, I believe all the tests will pass when we require
manifest_version 2 for unpacked extensions.)

BUG=62897
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113520

[Aaron Boodman, 2011-12-07 22:40:05]

lgtm

On Wed, Dec 7, 2011 at 2:36 PM,  <abarth@chromium.org> wrote:
> Reviewers: Aaron Boodman,
>
> Description:
> Mark WebNavigation tests as using legacy extension manifests.
>
> We could convert these tests to use manifest_version 2, but it's not worth
> the
> effort.  (After this patch, I believe all the tests will pass when we
> require
> manifest_version 2 for unpacked extensions.)
>
> BUG=62897
>
> Please review this at http://codereview.chromium.org/8864002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/extensions/extension_webnavigation_apitest.cc
>
>
> Index: chrome/browser/extensions/extension_webnavigation_apitest.cc
> ===================================================================
> --- chrome/browser/extensions/extension_webnavigation_apitest.cc
>  (revision 113424)
> +++ chrome/browser/extensions/extension_webnavigation_apitest.cc
>  (working copy)
> @@ -42,6 +42,9 @@
>  IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebNavigation) {
>   FrameNavigationState::set_allow_extension_scheme(true);
>
> +  CommandLine::ForCurrentProcess()->AppendSwitch(
> +      switches::kAllowLegacyExtensionManifests);
> +
>   ASSERT_TRUE(
>       RunExtensionSubtest("webnavigation", "test_api.html")) << message_;
>  }
> @@ -49,6 +52,9 @@
>  IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebNavigationGetFrame) {
>   FrameNavigationState::set_allow_extension_scheme(true);
>
> +  CommandLine::ForCurrentProcess()->AppendSwitch(
> +      switches::kAllowLegacyExtensionManifests);
> +
>   ASSERT_TRUE(
>       RunExtensionSubtest("webnavigation", "test_getFrame.html")) <<
> message_;
>  }
> @@ -56,6 +62,9 @@
>  IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebNavigationClientRedirect) {
>   FrameNavigationState::set_allow_extension_scheme(true);
>
> +  CommandLine::ForCurrentProcess()->AppendSwitch(
> +      switches::kAllowLegacyExtensionManifests);
> +
>   ASSERT_TRUE(
>       RunExtensionSubtest("webnavigation", "test_clientRedirect.html"))
>           << message_;
> @@ -66,6 +75,9 @@
>   host_resolver()->AddRule("*", "127.0.0.1");
>   ASSERT_TRUE(StartTestServer());
>
> +  CommandLine::ForCurrentProcess()->AppendSwitch(
> +      switches::kAllowLegacyExtensionManifests);
> +
>   ASSERT_TRUE(
>       RunExtensionSubtest("webnavigation", "test_serverRedirect.html"))
>           << message_;
> @@ -74,6 +86,9 @@
>  IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebNavigationForwardBack) {
>   FrameNavigationState::set_allow_extension_scheme(true);
>
> +  CommandLine::ForCurrentProcess()->AppendSwitch(
> +      switches::kAllowLegacyExtensionManifests);
> +
>   ASSERT_TRUE(
>       RunExtensionSubtest("webnavigation", "test_forwardBack.html"))
>           << message_;
> @@ -82,6 +97,9 @@
>  IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebNavigationIFrame) {
>   FrameNavigationState::set_allow_extension_scheme(true);
>
> +  CommandLine::ForCurrentProcess()->AppendSwitch(
> +      switches::kAllowLegacyExtensionManifests);
> +
>   ASSERT_TRUE(
>       RunExtensionSubtest("webnavigation", "test_iframe.html")) << message_;
>  }
> @@ -89,6 +107,9 @@
>  IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebNavigationOpenTab) {
>   FrameNavigationState::set_allow_extension_scheme(true);
>
> +  CommandLine::ForCurrentProcess()->AppendSwitch(
> +      switches::kAllowLegacyExtensionManifests);
> +
>   ASSERT_TRUE(
>       RunExtensionSubtest("webnavigation", "test_openTab.html")) <<
> message_;
>  }
> @@ -96,6 +117,9 @@
>  IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebNavigationReferenceFragment) {
>   FrameNavigationState::set_allow_extension_scheme(true);
>
> +  CommandLine::ForCurrentProcess()->AppendSwitch(
> +      switches::kAllowLegacyExtensionManifests);
> +
>   ASSERT_TRUE(
>       RunExtensionSubtest("webnavigation", "test_referenceFragment.html"))
>           << message_;
> @@ -104,6 +128,9 @@
>  IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebNavigationSimpleLoad) {
>   FrameNavigationState::set_allow_extension_scheme(true);
>
> +  CommandLine::ForCurrentProcess()->AppendSwitch(
> +      switches::kAllowLegacyExtensionManifests);
> +
>   ASSERT_TRUE(
>       RunExtensionSubtest("webnavigation", "test_simpleLoad.html")) <<
> message_;
>  }
> @@ -111,6 +138,9 @@
>  IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebNavigationFailures) {
>   FrameNavigationState::set_allow_extension_scheme(true);
>
> +  CommandLine::ForCurrentProcess()->AppendSwitch(
> +      switches::kAllowLegacyExtensionManifests);
> +
>   ASSERT_TRUE(
>       RunExtensionSubtest("webnavigation", "test_failures.html")) <<
> message_;
>  }
> @@ -118,6 +148,9 @@
>  IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebNavigationUserAction) {
>   FrameNavigationState::set_allow_extension_scheme(true);
>
> +  CommandLine::ForCurrentProcess()->AppendSwitch(
> +      switches::kAllowLegacyExtensionManifests);
> +
>   // Wait for the extension to set itself up and return control to us.
>   ASSERT_TRUE(
>       RunExtensionSubtest("webnavigation", "test_userAction.html")) <<
> message_;
> @@ -154,6 +187,9 @@
>  IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebNavigationRequestOpenTab) {
>   FrameNavigationState::set_allow_extension_scheme(true);
>
> +  CommandLine::ForCurrentProcess()->AppendSwitch(
> +      switches::kAllowLegacyExtensionManifests);
> +
>   // Wait for the extension to set itself up and return control to us.
>   ASSERT_TRUE(RunExtensionSubtest("webnavigation",
> "test_requestOpenTab.html"))
>       << message_;
>
>

[commit-bot: I haz the power, 2011-12-07 22:44:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/8864002/1

[zel, 2011-12-07 23:00:17]

On 2011/12/07 22:44:49, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/abarth%40chromium.org/8864002/1

I suppose this needs to be done in ChromeOS-specific extension API tests too -
right?

[abarth-chromium, 2011-12-07 23:03:25]

> I suppose this needs to be done in ChromeOS-specific extension API tests too -
> right?

Yes (or the test data needs to be converted to manifest_version 2).

I've updated all the extension tests I could find.  Is there a way for me to run
a ChromeOS try job to verify that I've gotten them all?  When I ran that on
Mac/Win/Linux, I found a few odds and ends that I missed in my global sweep.

[zel, 2011-12-07 23:06:09]

yes, you can run try with --bot=linux_chromeos



On Wed, Dec 7, 2011 at 3:03 PM, <abarth@chromium.org> wrote:

> I suppose this needs to be done in ChromeOS-specific extension API tests
>> too -
>> right?
>>
>
> Yes (or the test data needs to be converted to manifest_version 2).
>
> I've updated all the extension tests I could find.  Is there a way for me
> to run
> a ChromeOS try job to verify that I've gotten them all?  When I ran that on
> Mac/Win/Linux, I found a few odds and ends that I missed in my global
> sweep.
>
>
http://codereview.chromium.**org/8864002/<http://codereview.chromium.org/8864...
>

[abarth-chromium, 2011-12-08 00:24:46]

> yes, you can run try with --bot=linux_chromeos

Thanks.  Will do.