Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 8864: 1) Add a new MULTIPROCESS_TEST_MAIN macro to store child process names... (Closed)

Created:
12 years, 1 month ago by jeremy
Modified:
9 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

1) Add a new MULTIPROCESS_TEST_MAIN macro to store child process names in a lookup table. Previously we were using different mechanisms on each platform to look up child process names at runtime. This broke on OS X where we strip the symbol table on release executables. 2) Enable process_util_unittest on OS X. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4165

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -59 lines) Patch
M base/base.xcodeproj/project.pbxproj View 7 chunks +10 lines, -0 lines 0 comments Download
D base/base_unittest_exported_symbols.version View 1 chunk +0 lines, -5 lines 0 comments Download
M base/base_unittests.scons View 1 chunk +0 lines, -9 lines 0 comments Download
M base/multiprocess_test.h View 3 chunks +6 lines, -12 lines 0 comments Download
M base/port.h View 1 chunk +1 line, -6 lines 0 comments Download
M base/process_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/stats_table_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M base/test_suite.h View 1 2 2 chunks +2 lines, -24 lines 0 comments Download
M testing/SConscript.gtest View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M testing/gtest.vcproj View 1 chunk +4 lines, -0 lines 0 comments Download
M testing/gtest.xcodeproj/project.pbxproj View 4 chunks +6 lines, -0 lines 0 comments Download
A testing/multiprocess_func_list.h View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
A testing/multiprocess_func_list.cc View 1 2 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jeremy
Needed to kill the previous review because for some reason it wasn't seeing new patches. ...
12 years, 1 month ago (2008-10-28 23:59:18 UTC) #1
Mark Mentovai
12 years, 1 month ago (2008-10-29 13:38:13 UTC) #2
LGTM

http://codereview.chromium.org/8864/diff/15/26
File testing/multiprocess_func_list.h (right):

http://codereview.chromium.org/8864/diff/15/26#newcode1
Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
Just 2008 on new files.  Same on the other addition.

http://codereview.chromium.org/8864/diff/15/26#newcode5
Line 5: #ifndef TESTING_MULTIPROCESS_FUNC_LIST_H__
New style is to use just one trailing _.

http://codereview.chromium.org/8864/diff/15/26#newcode9
Line 9: #include <wchar.h>
What's this for?  I don't see anything in here that would require it.

http://codereview.chromium.org/8864/diff/15/26#newcode11
Line 11: namespace MultiProcessFunctionList {
Style sez namespaces_should_be_named_this_way AndNotThisWay.

http://codereview.chromium.org/8864/diff/15/26#newcode30
Line 30: // Example usage:
I think the bit with the example usage should move to the top of the header,
with a brief overview of what this all does and why.

http://codereview.chromium.org/8864/diff/15/26#newcode37
Line 37: // who's constructor does the work of adding the global mapping.
whose constructor

http://codereview.chromium.org/8864/diff/15/26#newcode46
Line 46: 
Nuke extra lines

Powered by Google App Engine
This is Rietveld 408576698