Store the host config in a per-host config file.

Store the host config in a per-host config file.


BUG=106795
TEST=Virtual Me2Me still works

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114066

[Lambros, 2011-12-08 00:25:56]

Fix silly bug.

[Wez, 2011-12-10 00:00:09]

LGTM, but I think the config filename should be based on a hash of the hostname,
so that strange hostnames can't break things in crazy ways.

http://codereview.chromium.org/8863010/diff/3001/remoting/tools/me2me_virtual...
File remoting/tools/me2me_virtual_host.py (right):

http://codereview.chromium.org/8863010/diff/3001/remoting/tools/me2me_virtual...
remoting/tools/me2me_virtual_host.py:269: "--%s=%s" % (HOST_CONFIG_SWITCH_NAME,
host.config_file)]
Is it possible for |config_file| to contain anything that might confuse popen()?
 (see below)

http://codereview.chromium.org/8863010/diff/3001/remoting/tools/me2me_virtual...
remoting/tools/me2me_virtual_host.py:294: host = Host(os.path.join(CONFIG_DIR,
"host#%s.json" % socket.gethostname()))
Is socket.gethostname() reliable, e.g. if the host has multiple names do we
always get the first?  (I think so, but I'm not sure...)

Can host names contain anything we'd be scared to have routed into a file path? 
Perhaps we should use a hash of the name, rather than the name itself?

[Lambros, 2011-12-10 02:00:31]

http://codereview.chromium.org/8863010/diff/3001/remoting/tools/me2me_virtual...
File remoting/tools/me2me_virtual_host.py (right):

http://codereview.chromium.org/8863010/diff/3001/remoting/tools/me2me_virtual...
remoting/tools/me2me_virtual_host.py:269: "--%s=%s" % (HOST_CONFIG_SWITCH_NAME,
host.config_file)]
On 2011/12/10 00:00:09, Wez wrote:
> Is it possible for |config_file| to contain anything that might confuse
popen()?
>  (see below)
This shouldn't confuse popen(), because the whole --%s=%s constitutes a single
item of the args[] list, with no shell parsing involved.  And
remoting_me2me_host ought to parse everything from the first '=' to the end of
that args[] item as the filename.

http://codereview.chromium.org/8863010/diff/3001/remoting/tools/me2me_virtual...
remoting/tools/me2me_virtual_host.py:294: host = Host(os.path.join(CONFIG_DIR,
"host#%s.json" % socket.gethostname()))
On 2011/12/10 00:00:09, Wez wrote:
> Is socket.gethostname() reliable, e.g. if the host has multiple names do we
> always get the first?  (I think so, but I'm not sure...)
Python doc isn't helpful here, it says only that it returns the machine's
hostname.  socket.getfqdn() may be better, I'm not sure.

> 
> Can host names contain anything we'd be scared to have routed into a file
path? 
> Perhaps we should use a hash of the name, rather than the name itself?
Yeah.  The gotcha is that hostnames can be 255 chars long, which is also the
limit for UNIX filenames.  The allowed characters for hostnames (alphanum, dash,
dot) are OK here.  The problem is just the maximum length :)

Done.

[Wez, 2011-12-12 23:47:53]

lgtm