Issue 8863003: Use -wipe-data on emulator launch to improve android bot reliability.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8863003: Use -wipe-data on emulator launch to improve android bot reliability. (Closed)

Created:
9 years ago by John Grabowski

Modified:
9 years ago

Reviewers:
bulach

CC:
chromium-reviews, Peter Beverloo

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use -wipe-data on emulator launch to improve android bot reliability. BUG=None TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113492

Patch Set 1 #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -9 lines)			Patch
	M	build/android/emulator.py	View		3 chunks	+19 lines, -9 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bulach

LGTM, one suggestion: http://codereview.chromium.org/8863003/diff/1/build/android/emulator.py File build/android/emulator.py (right): http://codereview.chromium.org/8863003/diff/1/build/android/emulator.py#newcode133 build/android/emulator.py:133: self.popen = subprocess.Popen(args=emulator_command, nit: popen is ...

9 years ago (2011-12-07 22:55:57 UTC) #2

John Grabowski

9 years ago (2011-12-07 22:57:31 UTC) #3

Thx for review

http://codereview.chromium.org/8863003/diff/1/build/android/emulator.py
File build/android/emulator.py (right):

http://codereview.chromium.org/8863003/diff/1/build/android/emulator.py#newco...
build/android/emulator.py:133: self.popen =
subprocess.Popen(args=emulator_command,
On 2011/12/07 22:55:57, bulach wrote:
> nit: popen is too generic.. perhaps rather than self.popen, use
> self.emulator_process?

It returns a popen object.
Class is emulator so I emulator_popen_object is a bit redundant.

Expand Messages | Collapse Messages