Installing a platform application will add all application shortucts.

Installing a platform application will add all application shortucts.

Applications shortcuts will be added to the Start / Applications menu,
the taskbar and the desktop. This is a temporary change to help the
shortcut features of platform applications and make installed platform
applications more visible.

BUG=None
TEST=Manually tested on Windows


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114006

[benwells, 2011-12-09 03:35:40]

+miket

[miket_OOO, 2011-12-09 18:42:02]

LGTM

http://codereview.chromium.org/8862007/diff/6001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_service.cc (right):

http://codereview.chromium.org/8862007/diff/6001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_service.cc:393: tracker_(this) {
Please see
http://codesearch.google.com/#OAMlx_jo-ck/src/base/compiler_specific.h&exact_...

http://codereview.chromium.org/8862007/diff/6001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_service.cc:2538: // Look for an icon.  If
there is no icon at the ideal size,
Prevailing style calls for single space after period. Also see
http://www.slate.com/articles/technology/technology/2011/01/space_invaders.html

http://codereview.chromium.org/8862007/diff/6001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_service.cc:2552: }
Is another .empty() case possible at this point? (I don't know.)

[benwells, 2011-12-12 03:02:59]

Comments addressed; committing now.

http://codereview.chromium.org/8862007/diff/6001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_service.cc (right):

http://codereview.chromium.org/8862007/diff/6001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_service.cc:393: tracker_(this) {
On 2011/12/09 18:42:02, miket wrote:
> Please see
>
http://codesearch.google.com/#OAMlx_jo-ck/src/base/compiler_specific.h&exact_...

Done.

http://codereview.chromium.org/8862007/diff/6001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_service.cc:2538: // Look for an icon.  If
there is no icon at the ideal size,
On 2011/12/09 18:42:02, miket wrote:
> Prevailing style calls for single space after period. Also see
>
http://www.slate.com/articles/technology/technology/2011/01/space_invaders.html

Point taken! As a committed single spacer, I will be more careful in future when
copying comments from old code :)

http://codereview.chromium.org/8862007/diff/6001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_service.cc:2552: }
On 2011/12/09 18:42:02, miket wrote:
> Is another .empty() case possible at this point? (I don't know.)

Yes, but the LoadImage call and OnImageLoaded callback handle this situation.
I've added comments to make this obvious.

[commit-bot: I haz the power, 2011-12-12 05:59:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/8862007/11002

[commit-bot: I haz the power, 2011-12-12 08:02:17]

Try job failure for 8862007-11002 (retry) on win_rel for step "browser_tests".
It's a second try, previously, steps "browser_tests, ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2011-12-12 09:47:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/8862007/11002

[commit-bot: I haz the power, 2011-12-12 11:06:42]

Change committed as 114006

[Aaron Boodman, 2012-02-01 01:31:42]

http://codereview.chromium.org/8862007/diff/11002/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_service.cc (right):

http://codereview.chromium.org/8862007/diff/11002/chrome/browser/extensions/e...
chrome/browser/extensions/extension_service.cc:2122:
StartInstallApplicationShortcut(extension);
indent

http://codereview.chromium.org/8862007/diff/11002/chrome/browser/extensions/e...
chrome/browser/extensions/extension_service.cc:2538: void
ExtensionService::StartInstallApplicationShortcut(
Please don't put random stuff like this in ExtensionService. I don't know where
it should go, but not here.