Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: runtime/vm/parser.cc

Issue 8862002: Fix handling of unresolved upper bounds in factory declarations (issue 721). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 2197)
+++ runtime/vm/parser.cc (working copy)
@@ -2346,8 +2346,9 @@
*(member.name)));
const Class& signature_class = Class::Handle(
Class::New(String::Handle(String::NewSymbol(":factory_signature")),
- Script::Handle()));
+ script_));
signature_class.set_is_finalized();
+ signature_class.set_library(library_);
unresolved_factory_class.set_factory_signature_class(signature_class);
// The type arguments of the result type are set during finalization.
const TypeArguments& args = TypeArguments::Handle();
@@ -2762,7 +2763,8 @@
UnresolvedClass::New(factory_pos, qualifier, *(factory_name.ident)));
const Class& signature_class = Class::Handle(
Class::New(String::Handle(String::NewSymbol(":factory_signature")),
- Script::Handle()));
+ script_));
+ signature_class.set_library(library_);
signature_class.set_is_finalized();
ParseTypeParameters(signature_class);
unresolved_factory_class.set_factory_signature_class(signature_class);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698