Some visual tweaks to the virtual keyboard.

Some visual tweaks to the virtual keyboard.

BUG=none
TEST=manually


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113652

[bryeung, 2011-12-07 19:24:19]

mazda: this is the same patch as http://codereview.chromium.org/8827012/ with
your nit addressed.  Somehow the owner of the other issue is wrong, so I've
uploaded it in a new issue.

arv: can you please review for OWNERS?

[mazda, 2011-12-07 20:08:47]

lgtm

[arv (Not doing code reviews), 2011-12-07 21:19:59]

LGTM

http://codereview.chromium.org/8859001/diff/1/chrome/browser/resources/keyboa...
File chrome/browser/resources/keyboard/main.css (right):

http://codereview.chromium.org/8859001/diff/1/chrome/browser/resources/keyboa...
chrome/browser/resources/keyboard/main.css:40: margin-right: 5px;
Should this be -webkit-margin-end?

http://codereview.chromium.org/8859001/diff/1/chrome/browser/resources/keyboa...
File chrome/browser/resources/keyboard/shift-down.svg (right):

http://codereview.chromium.org/8859001/diff/1/chrome/browser/resources/keyboa...
chrome/browser/resources/keyboard/shift-down.svg:2: <!-- Generator: Adobe
Illustrator 14.0.0, SVG Export Plug-In . SVG Version: 6.00 Build 43363)  -->
remove generator comment?

http://codereview.chromium.org/8859001/diff/1/chrome/browser/resources/keyboa...
chrome/browser/resources/keyboard/shift-down.svg:4: <svg version="1.1"
id="Layer_1" xmlns="http://www.w3.org/2000/svg"
xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px" width="50px"
height="50px" viewBox="10 10 30 30">
Layer_1 is never used

http://codereview.chromium.org/8859001/diff/1/chrome/browser/resources/keyboa...
chrome/browser/resources/keyboard/shift-down.svg:4: <svg version="1.1"
id="Layer_1" xmlns="http://www.w3.org/2000/svg"
xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px" width="50px"
height="50px" viewBox="10 10 30 30">
xlink is never used

[bryeung, 2011-12-08 19:01:52]

Thanks for the suggestions.

http://codereview.chromium.org/8859001/diff/1/chrome/browser/resources/keyboa...
File chrome/browser/resources/keyboard/main.css (right):

http://codereview.chromium.org/8859001/diff/1/chrome/browser/resources/keyboa...
chrome/browser/resources/keyboard/main.css:40: margin-right: 5px;
On 2011/12/07 21:20:00, arv wrote:
> Should this be -webkit-margin-end?

Since this is laying out keyboard, and I don't think the layout would change in
a RTL context, I think margin-right is correct here.  Let me know if I'm
misunderstanding margin-end.

[commit-bot: I haz the power, 2011-12-08 19:02:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bryeung@chromium.org/8859001/6001

[commit-bot: I haz the power, 2011-12-08 20:46:56]

Change committed as 113652