Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 8857004: Delete UDPClientSocket on same thread as creation. Also refactor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: aa-inspired deltas. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index 67b0f4dcc6a9efbc8c16dec0d7746f0297a31b37..c5a2ccd9cd254fde90314dc4e16040db354cc5bb 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -75,6 +75,7 @@ class ExtensionInputMethodEventRouter;
namespace extensions {
class ComponentLoader;
class SettingsFrontend;
+class SocketController;
}
// This is an interface class to encapsulate the dependencies that
@@ -569,6 +570,10 @@ class ExtensionService
return &extension_warnings_;
}
+ extensions::SocketController* socket_controller() {
+ return socket_controller_;
+ }
+
private:
// Bundle of type (app or extension)-specific sync stuff.
struct SyncBundle {
@@ -685,6 +690,9 @@ class ExtensionService
NaClModuleInfoList::iterator FindNaClModule(const GURL& url);
+ static void DeleteSocketController(
+ extensions::SocketController* socket_controller);
+
// The profile this ExtensionService is part of.
Profile* profile_;
@@ -819,6 +827,10 @@ class ExtensionService
// Contains an entry for each warning that shall be currently shown.
ExtensionWarningSet extension_warnings_;
+ // We need to control destruction of this object (it needs to happen on the
+ // IO thread), so we don't get to use any RAII devices with it.
+ extensions::SocketController* socket_controller_;
+
extensions::ProcessMap process_map_;
FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,

Powered by Google App Engine
This is Rietveld 408576698