Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: chrome/browser/sync/engine/get_commit_ids_command.cc

Issue 8856007: [Sync] Special case nigori when calculating commit id's. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/engine/get_commit_ids_command.cc
diff --git a/chrome/browser/sync/engine/get_commit_ids_command.cc b/chrome/browser/sync/engine/get_commit_ids_command.cc
index 3000649c44510ece1d7c26f5cfde0c6493901ef1..4c280ecd644401982bb3e69e71a8fe24d01fff18 100644
--- a/chrome/browser/sync/engine/get_commit_ids_command.cc
+++ b/chrome/browser/sync/engine/get_commit_ids_command.cc
@@ -94,7 +94,11 @@ bool IsEntryReadyForCommit(const syncable::ModelTypeSet& encrypted_types,
}
syncable::ModelType type = entry.GetModelType();
- if (encrypted_types.count(type) > 0 &&
+ // We special case the nigori node because even though it is considered an
+ // "encrypted type", not all nigori node changes require valid encryption
+ // (ex: sync_tabs).
+ if (type != syncable::NIGORI &&
+ encrypted_types.count(type) > 0 &&
(passphrase_missing ||
syncable::EntryNeedsEncryption(encrypted_types, entry))) {
// This entry requires encryption but is not properly encrypted (possibly
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698