Issue 8856007: [Sync] Special case nigori when calculating commit id's.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8856007: [Sync] Special case nigori when calculating commit id's. (Closed)

Created:
9 years ago by Nicolas Zea

Modified:
9 years ago

Reviewers:
Yaron

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Sync] Special case nigori when calculating commit id's. We special case the nigori node because even though it is considered an "encrypted type", not all nigori node changes require valid encryption (ex: sync_tabs). BUG=106619 TEST=none. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113550

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	chrome/browser/sync/engine/get_commit_ids_command.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

PTAL, and if possible test this locally to ensure this fixes the bug.

9 years ago (2011-12-07 19:26:34 UTC) #1

Yaron

On 2011/12/07 19:26:34, nzea wrote: > PTAL, and if possible test this locally to ensure ...

9 years ago (2011-12-07 20:19:14 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/8856007/1

9 years ago (2011-12-07 20:55:47 UTC) #3

commit-bot: I haz the power

Try job failure for 8856007-1 (retry) on mac_rel for step "ui_tests" (clobber build). It's a ...

9 years ago (2011-12-07 22:43:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/8856007/1

9 years ago (2011-12-08 01:33:18 UTC) #5

Change committed as 113550

Expand Messages | Collapse Messages