Issue 8856005: SQLitePersistentCookieStore fix: Don't abuse SQL_FROM_HERE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8856005: SQLitePersistentCookieStore fix: Don't abuse SQL_FROM_HERE. (Closed)

Created:
9 years ago by marja

Modified:
9 years ago

Reviewers:
erikwright (departed), Randy Smith (Not in Mondays)

CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright (departed), wtc, darin-cc_chromium.org, rkn

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

SQLitePersistentCookieStore fix: Don't abuse SQL_FROM_HERE. SQL_FROM_HERE cannot be used in places where the corresponding SQL statement is not unique. BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113575

Patch Set 1 #

Patch Set 2 : Simplifying. #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
	M	chrome/browser/net/sqlite_persistent_cookie_store.cc	View	1	1 chunk	+11 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

marja

erikwright, thanks for review! I removed the bug number (was 106722), this probably is not ...

9 years ago (2011-12-07 20:27:45 UTC) #3

Randy Smith (Not in Mondays)

On 2011/12/07 20:27:45, marja wrote: > erikwright, thanks for review! > > I removed the ...

9 years ago (2011-12-07 20:29:42 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/8856005/4001

9 years ago (2011-12-08 07:30:50 UTC) #5

Change committed as 113575

Expand Messages | Collapse Messages