Abort in-flight load tasks if the DB has been closed.

Abort in-flight load tasks if the DB has been closed.

I suspect that the crashes reported in M17 are because the SQLitePersistentCookieStore is closed while it was still loading.

This CL adds checks that should abort all tasks that access db_, if db_ is NULL.

R=rdsmith@chromium.org
BUG=106722
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113498

[Randy Smith (Not in Mondays), 2011-12-07 21:12:06]

LGTM.  (I debated asking for a comment as to why the
LoadKeyAndNotifyOnDBThread->LoadCookiesForDomains path was safe, but decided it
was clear enough from inspecting LoadKeyAndNotifyOnDBThread.  But I mention it
incase you disagree :-}).

[commit-bot: I haz the power, 2011-12-07 21:16:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikwright@chromium.org/8855009/1

[erikwright (departed), 2011-12-07 21:17:36]

On 2011/12/07 21:12:06, rdsmith wrote:
> LGTM.  (I debated asking for a comment as to why the
> LoadKeyAndNotifyOnDBThread->LoadCookiesForDomains path was safe, but decided
it
> was clear enough from inspecting LoadKeyAndNotifyOnDBThread.  But I mention it
> incase you disagree :-}).

In general it's quite hard to reason about, the way the code stands. I don't
think this one comment would help.

The answer, in case it isn't the same one you reasoned out, is that
LoadKeyAnd... calls InitializeDb, which was updated to fail under these
conditions.

[commit-bot: I haz the power, 2011-12-07 23:10:14]

Change committed as 113498