Issue 8854007: Add checks to delegate in SigninScreenHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8854007: Add checks to delegate in SigninScreenHandler (Closed)

Created:
9 years ago by stevenjb

Modified:
9 years ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add checks to delegate in SigninScreenHandler Inspection does not reveal any obvious paths that would lead to the crash in chromium-os:22577, so adding checks to help isolate the root cause. BUG=chromium-os:22577 TEST=Run all tests, look for crashes with the signature described in the issue. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113668

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/browser/chromeos/login/webui_login_display_host.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/8854007/1

9 years ago (2011-12-08 19:35:21 UTC) #3

Change committed as 113668

Expand Messages | Collapse Messages